1401654 - Move MOZ_WEBRTC et al. to moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

I had a patch to do this written and tested. Not sure if it's going to end up blocking other stuff, but it's worth landing anyway.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1401654 - Move MOZ_WEBRTC and some related defines to moz.configure.

Review commit: https://reviewboard.mozilla.org/r/181882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181882/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8910448 [details]
Bug 1401654 - Move MOZ_WEBRTC and some related defines to moz.configure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181882/diff/1-2/

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8910448 [details]
Bug 1401654 - Move MOZ_WEBRTC and some related defines to moz.configure.

https://reviewboard.mozilla.org/r/181882/#review187602

::: toolkit/moz.configure:1197
(Diff revision 2)
> +
> +    if os_match and cpu_match:
> +        return True
> +    return False
> +
> +option('--disable-webrtc', default=webrtc_default,

It looks like the other --disable options don't have a default, but instead do the per-target default logic in the equivalent of the webrtc() function. Is this approach better because you don't have to check the origin of the --disable-webrtc flag in that function? I was slightly confused at first since the default value seems inverted with the --disable flags (ie: if webrtc_default() returns True, that means we are not using --disable-webrtc).

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8910448 [details]
Bug 1401654 - Move MOZ_WEBRTC and some related defines to moz.configure.

https://reviewboard.mozilla.org/r/181882/#review187602

> It looks like the other --disable options don't have a default, but instead do the per-target default logic in the equivalent of the webrtc() function. Is this approach better because you don't have to check the origin of the --disable-webrtc flag in that function? I was slightly confused at first since the default value seems inverted with the --disable flags (ie: if webrtc_default() returns True, that means we are not using --disable-webrtc).

Yeah, it's preferable to checking the origin in cases we aren't forcing the value to be enable/disabled anywhere.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2ab042f20e4
Move MOZ_WEBRTC and some related defines to moz.configure. r=mshal

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d2ab042f20e4