1401659 - Remove integrations-tests file

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Jason Laster [:jlast]]

We checked in an integrations-tests bundle last spring to see if we could run the mochitests w/ a single bundle file, which would run in any context. We're no longer trying to do this, so we can remove that file.

Comment 1

[Jason Laster [:jlast]]

Attachment: int-file.patch

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6cf8489e899ea55cc1df27106f0e76e1ad20e41

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8910409 [details] [diff] [review]
int-file.patch

Review of attachment 8910409 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks good to me. More cleanup to do if you're in the mood:

Did a quick search and the file is referenced in two mochitests which are not listed in browser.ini:
- devtools/client/debugger/new/test/mochitest/browser_dbg-asm.js
- devtools/client/debugger/new/test/mochitest/browser_dbg-returnvalues.js

So I got curious and looked if there were others:
- devtools/client/debugger/new/test/mochitest/browser_dbg-asm.js
- devtools/client/debugger/new/test/mochitest/browser_dbg-breaking.js
- devtools/client/debugger/new/test/mochitest/browser_dbg-editor-mode.js
- devtools/client/debugger/new/test/mochitest/browser_dbg-returnvalues.js

Comment 4

[Jason Laster [:jlast]]

Okay, so... asm and return_values are two tests that were corrupted last march when we reverted the integration stuff. We fixed asm this week, i'll fix returnvalues when we fix the feature. These two tests should be fixed in debugger.html and CP'd into MC.

what is the list of the other 4 tests?

Comment 5

[Julian Descottes [:jdescottes]]

They are not listed in browser.ini so never run. 

browser_dbg-breaking.js actually is in the list (not alphabetically sorted so I missed it :/)
browser_dbg-asm.js I already mentioned previously. 

So just two tests: 
- devtools/client/debugger/new/test/mochitest/browser_dbg-editor-mode.js
- devtools/client/debugger/new/test/mochitest/browser_dbg-returnvalues.js

I guess they should be deleted?

Comment 6

[Julian Descottes [:jdescottes]]

(In reply to Julian Descottes [:jdescottes] from comment #5)
> They are not listed in browser.ini so never run. 
> 
> browser_dbg-breaking.js actually is in the list (not alphabetically sorted
> so I missed it :/)
> browser_dbg-asm.js I already mentioned previously. 
> 
> So just two tests: 
> - devtools/client/debugger/new/test/mochitest/browser_dbg-editor-mode.js
> - devtools/client/debugger/new/test/mochitest/browser_dbg-returnvalues.js
> 
> I guess they should be deleted?

Erf of course returnvalues was also mentioned previously :) So just browser_dbg-editor-mode.js!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56a2f9812f9d
Remove integrations-tests file. r=jdescottes

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/56a2f9812f9d