1401662 - don't inline nsThreadManager::get()

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Nathan Froyd [:froydnj]]

Defining get() in the declaration of nsThreadManager implicitly sticks
an "inline" on the function, which is not what we want: inlining it
spreads around a lot of static initialization code.  Providing an
out-of-line definition is much better in terms of code size.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: don't inline nsThreadManager::get()

Small codesize win.

Comment 2

[Eric Rahm [:erahm]]

Comment on attachment 8910410 [details] [diff] [review]
don't inline nsThreadManager::get()

Review of attachment 8910410 [details] [diff] [review]:
-----------------------------------------------------------------

I imagine this is a pretty common pattern, should we look for other instances of this?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a88ee0137c10
don't inline nsThreadManager::get(); r=erahm

Comment 4

[Nathan Froyd [:froydnj]]

That's an excellent idea; a quick grep shows a couple of other instances of things like this.  Will file bugs tomorrow.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a88ee0137c10