Closed Bug 1401710 Opened 2 years ago Closed 2 years ago

Remove unused unsafe code from nsDOMClassInfo

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

There are two implementations of do_QueryWrappedNative with the warning "THIS ONE ISN'T SAFE!!" that fortunately aren't used, so I think they should just be deleted. They are the only callers of nsDOMClassInfo::GetNative(), which seems to be the source of unsafety, and XPConnect(), which is just not used.
This builds and runs locally on Linux, and SearchFox didn't find any other uses of these things, so hopefully that's sufficient checking.
Comment on attachment 8910463 [details]
Bug 1401710 - Remove unused unsafe code from nsDOMClassInfo.

https://reviewboard.mozilla.org/r/181902/#review187386

r=me
Attachment #8910463 - Flags: review?(bzbarsky) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc2264fce0d4
Remove unused unsafe code from nsDOMClassInfo. r=bz
https://hg.mozilla.org/mozilla-central/rev/fc2264fce0d4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.