1401737 - Crash in java.lang.IllegalStateException: Already registered Gecko:ScheduleRun at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java)

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-4c6ccee1-add1-4c47-a355-159020170920.
=============================================================

First crash was with the 9-14 Nightly. Seems like GeckoApplication.onCreate is getting called multiple times.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 1. Add a diagnostic crash (v1)

Add a diagnostic crash for the unexpected case where
GeckoService.register() is called a second time. We know the stack for
the second call, but we want to know the stack for the first call, so we
introduce this intentional crash. r=me for trivial diagnostic patch
which will be backed out ASAP.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40023b79401d
1. Add a diagnostic crash; r=me

Comment 3

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/40023b79401d

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Add GeckoAppShell.appendAppNotesToCrashReport (v1)

Add a way to append app notes to the crash report from Java, so we can
associate additional crash data with the crash.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 3. Consolidate GeckoAppShell initialization (v1)

Consolidate GeckoAppShell initialization to GeckoApplication.onCreate
instead of spreading it out over different Activities. r=me for trivial
patch.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 4. Moar diagnostic crash (v1)

Back out the part 1 diagnostic crash and introduce another diagnostic
crash that will hopefully include more details. r=me for trivial patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70203c5f6d17
2. Add GeckoAppShell.appendAppNotesToCrashReport; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9224d3e7de6
3. Consolidate GeckoAppShell initialization; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c9bf73f5a4e
4. Moar diagnostic crash; r=me

Comment 8

[Calixte Denizet (:calixte)]

There are 28 crashes with signature "java.lang.IllegalStateException: Bug 1401737 diagnostic crash at org.mozilla.gecko.GeckoService.register(GeckoService.java)" in nightly 58 starting with buildid 20170928100122.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/70203c5f6d17
https://hg.mozilla.org/mozilla-central/rev/e9224d3e7de6
https://hg.mozilla.org/mozilla-central/rev/9c9bf73f5a4e

Comment 10

[Calixte Denizet (:calixte)]

There are 5 crashes in nightly with signature "java.lang.IllegalStateException: Bug 1401737 diagnostic crash 2 at org.mozilla.gecko.GeckoApplication.onCreate(GeckoApplication.java)"
:jchen, could you investigate please ?

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 5. Revert diagnostic crash (v1)

Comment 12

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 6. Handle GeckoApplication recreation (v1)

Handle rare cases where GeckoApplication is recreated when Fennec is
alive. In such cases, we need to unregister certain event listeners from
the old GeckoApplication so we can register again under the new one.
Also make GeckoActivityMonitor and TelemetryBackgroundReceiver better
handle GeckoApplication instance changes.

Comment 13

[Eugen Sawin [:esawin]]

Comment on attachment 8917038 [details] [diff] [review]
6. Handle GeckoApplication recreation (v1)

Review of attachment 8917038 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/telemetry/TelemetryBackgroundReceiver.java
@@ +74,5 @@
>      private static final String DEFAULT_PROFILE = "default";
>  
>      private static final TelemetryBackgroundReceiver instance = new TelemetryBackgroundReceiver();
>  
> +    private boolean initialized;

mInitialized, although non-GeckoView Java code seems to suffer from inconsistent code styles.

Comment 14

[(inactive) Jim Chen [:jchen] [:darchons]]

Yeah, that file seems to use the no-prefix style (see `instance` above).

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea3bce858583
5. Revert diagnostic crash; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/be0cfcefed97
6. Handle GeckoApplication recreation; r=esawin

Comment 16

[(inactive) Jim Chen [:jchen] [:darchons]]

[Tracking Requested - why for this release]:

Comment 17

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ea3bce858583
https://hg.mozilla.org/mozilla-central/rev/be0cfcefed97

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Is this something we should be considering for 57 backport or can it ride the 58 train?

Comment 19

[Ryan VanderMeulen [:RyanVM]]

I'll assume this is a wontfix given where we are in the cycle.