Closed
Bug 1401737
Opened 4 years ago
Closed 3 years ago
Crash in java.lang.IllegalStateException: Already registered Gecko:ScheduleRun at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java)
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec+, firefox56 unaffected, firefox57 wontfix, firefox58 fixed)
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
fennec | + | --- |
firefox56 | --- | unaffected |
firefox57 | --- | wontfix |
firefox58 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
(Keywords: crash)
Crash Data
Attachments
(6 files)
1.84 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
6.73 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
6.47 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
3.87 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
2.29 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
8.74 KB,
patch
|
esawin
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-4c6ccee1-add1-4c47-a355-159020170920. ============================================================= First crash was with the 9-14 Nightly. Seems like GeckoApplication.onCreate is getting called multiple times.
Assignee | ||
Comment 1•4 years ago
|
||
Add a diagnostic crash for the unexpected case where GeckoService.register() is called a second time. We know the stack for the second call, but we want to know the stack for the first call, so we introduce this intentional crash. r=me for trivial diagnostic patch which will be backed out ASAP.
Attachment #8911032 -
Flags: review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/40023b79401d 1. Add a diagnostic crash; r=me
![]() |
||
Comment 3•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/40023b79401d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Assignee | ||
Updated•4 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 4•3 years ago
|
||
Add a way to append app notes to the crash report from Java, so we can associate additional crash data with the crash.
Attachment #8915229 -
Flags: review?(snorp)
Assignee | ||
Comment 5•3 years ago
|
||
Consolidate GeckoAppShell initialization to GeckoApplication.onCreate instead of spreading it out over different Activities. r=me for trivial patch.
Attachment #8915230 -
Flags: review+
Assignee | ||
Comment 6•3 years ago
|
||
Back out the part 1 diagnostic crash and introduce another diagnostic crash that will hopefully include more details. r=me for trivial patch.
Attachment #8915231 -
Flags: review+
Attachment #8915229 -
Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/70203c5f6d17 2. Add GeckoAppShell.appendAppNotesToCrashReport; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/e9224d3e7de6 3. Consolidate GeckoAppShell initialization; r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/9c9bf73f5a4e 4. Moar diagnostic crash; r=me
Assignee | ||
Updated•3 years ago
|
Keywords: leave-open
Comment 8•3 years ago
|
||
There are 28 crashes with signature "java.lang.IllegalStateException: Bug 1401737 diagnostic crash at org.mozilla.gecko.GeckoService.register(GeckoService.java)" in nightly 58 starting with buildid 20170928100122.
Crash Signature: [@ java.lang.IllegalStateException: Already registered Gecko:ScheduleRun at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java)] → [@ java.lang.IllegalStateException: Already registered Gecko:ScheduleRun at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java)]
[@ java.lang.IllegalStateException: Bug 1401737 diagnostic crash at org.mozilla.gecko.GeckoService.regis…
Comment 9•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/70203c5f6d17 https://hg.mozilla.org/mozilla-central/rev/e9224d3e7de6 https://hg.mozilla.org/mozilla-central/rev/9c9bf73f5a4e
Comment 10•3 years ago
|
||
There are 5 crashes in nightly with signature "java.lang.IllegalStateException: Bug 1401737 diagnostic crash 2 at org.mozilla.gecko.GeckoApplication.onCreate(GeckoApplication.java)" :jchen, could you investigate please ?
Crash Signature: org.mozilla.gecko.GeckoService.register(GeckoService.java)] → org.mozilla.gecko.GeckoService.register(GeckoService.java)]
[@ java.lang.IllegalStateException: Bug 1401737 diagnostic crash 2 at org.mozilla.gecko.GeckoApplication.onCreate(GeckoApplication.java)]
Flags: needinfo?(nchen)
Assignee | ||
Comment 11•3 years ago
|
||
Attachment #8917037 -
Flags: review+
Assignee | ||
Comment 12•3 years ago
|
||
Handle rare cases where GeckoApplication is recreated when Fennec is alive. In such cases, we need to unregister certain event listeners from the old GeckoApplication so we can register again under the new one. Also make GeckoActivityMonitor and TelemetryBackgroundReceiver better handle GeckoApplication instance changes.
Attachment #8917038 -
Flags: review?(esawin)
Comment 13•3 years ago
|
||
Comment on attachment 8917038 [details] [diff] [review] 6. Handle GeckoApplication recreation (v1) Review of attachment 8917038 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/java/org/mozilla/gecko/telemetry/TelemetryBackgroundReceiver.java @@ +74,5 @@ > private static final String DEFAULT_PROFILE = "default"; > > private static final TelemetryBackgroundReceiver instance = new TelemetryBackgroundReceiver(); > > + private boolean initialized; mInitialized, although non-GeckoView Java code seems to suffer from inconsistent code styles.
Attachment #8917038 -
Flags: review?(esawin) → review+
Assignee | ||
Comment 14•3 years ago
|
||
Yeah, that file seems to use the no-prefix style (see `instance` above).
Flags: needinfo?(nchen)
Comment 15•3 years ago
|
||
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ea3bce858583 5. Revert diagnostic crash; r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/be0cfcefed97 6. Handle GeckoApplication recreation; r=esawin
Assignee | ||
Comment 16•3 years ago
|
||
[Tracking Requested - why for this release]:
![]() |
||
Comment 17•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ea3bce858583 https://hg.mozilla.org/mozilla-central/rev/be0cfcefed97
Status: REOPENED → RESOLVED
Closed: 4 years ago → 3 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
status-firefox56:
--- → unaffected
Comment 18•3 years ago
|
||
Is this something we should be considering for 57 backport or can it ride the 58 train?
Flags: needinfo?(snorp)
tracking-fennec: ? → +
Flags: needinfo?(snorp)
Comment 19•3 years ago
|
||
I'll assume this is a wontfix given where we are in the cycle.
Updated•2 months ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•