Closed Bug 1401773 Opened 2 years ago Closed 2 years ago

Revert checkboxes->switches changeover for SyncPrefs

Categories

(Firefox for Android :: Firefox Accounts, defect)

Product:
Firefox for Android
Component:
Firefox Accounts
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: Grisha, Assigned: Grisha)

References

Details

Attachments

(1 file)

Bug 1401773 - Revert checkboxes->switches changeover for SyncPrefs
59 bytes, text/x-review-board-request
nalexander
: review+
Details 
I'm seeing strange behaviour on older devices - specifically, on API16 dirty switches just reset back to their previous positions after syncing begins, thus making it impossible to change "what to sync" set.

On newer API levels (26), I'm seeing that incoming changes to the enabled engines set aren't reflected in the switches.

So, this clearly needs some more work. Bug 1401772 tracks this work, but for now let's just revert this change since there's no more 57 nightly time remaining.
Comment on attachment 8910523 [details]
Bug 1401773 - Revert checkboxes->switches changeover for SyncPrefs

https://reviewboard.mozilla.org/r/181954/#review187286
Attachment #8910523 - Flags: review?(nalexander) → review+
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
Pushed by gkruglov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc85108a0a30
Revert checkboxes->switches changeover for SyncPrefs r=nalexander
https://hg.mozilla.org/mozilla-central/rev/dc85108a0a30
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.