Closed Bug 1401814 Opened 2 years ago Closed 2 years ago

Enable crash reporter in linux64-ccov builds

Categories

(Testing :: Code Coverage, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox58 --- fixed

People

(Reporter: marco, Assigned: marco)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The crash reporter is currently disabled in code coverage builds [1].

We should try to enable it, as it makes debugging crashes on automation easier (see for example bug 1395390).

[1]: https://hg.mozilla.org/mozilla-central/file/ffe6cc09ccf38cca6f0e727837bbc6cb722d1e71/browser/config/mozconfigs/linux64/code-coverage#l7
Here's a try build with the crash reporter enabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0475b90ae391f948333b9d7ec819c00b00033c2c. Let's see if there are failures.
Attached patch PatchSplinter Review
(In reply to Marco Castelluccio [:marco] from comment #1)
> Here's a try build with the crash reporter enabled:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=0475b90ae391f948333b9d7ec819c00b00033c2c. Let's see
> if there are failures.

I only see some intermittents, but nothing that could be due to enabling the crash reporter.

Luckily, one of the intermittents is a crash and so we can verify that with this option removed we indeed see stack traces in the test logs: https://treeherder.mozilla.org/logviewer.html#?job_id=132364388&repo=try&lineNumber=11605.
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8910693 - Flags: review?(jmaher)
Attachment #8910693 - Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69c2f0ea56dd
Don't disable crash reporter in coverage builds. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/69c2f0ea56dd
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.