1401835 - Hide page action buttons when the URL bar gets small

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Nihanth Subramanya [:nhnt11]]

They're all accessible from the page action menu anyway, so when space is short we could hide them one by one like we do with toolbar buttons as the window gets small. This leaves more space for the identity box and actual URL text, which are in my opinion more important.

Comment 1

[Drew Willcoxon :adw]

Aaron, any thoughts here?  I think you all have given some thought to page actions customization beyond 57, and maybe this is slightly related?

Comment 2

[Aaron Benson]

Yeah, lets allow the page action icons to move into the Page Action Menu one-at-a-time, including the bookmark star if needed. It might be worth condensing the security label a little earlier or more aggressively, but that should probably be handled in a different bug and with more thought/clarity :)

Comment 3

[Aaron Benson]

Attachment: extensions_label_awesomebar.png

The extensions label should also be dropped first when screen widths become narrow.

Comment 5

[Mike de Boer [:mikedeboer]]

Copying over comments from bug 1598563:

Drew, since you did the initial implementation of the action buttons, does this make sense to you? The idea here is that when a certain width threshold of the URLBar is hit - whilst the user is resizing the window, for example - that the action buttons that are visible in the URLBar start flowing back into the meatball menu.
I acknowledge that this adds another state/ mode for the buttons to be, which slightly complicates things when customizing the action buttons whilst their overflowing (inside the menu temporarily), but since that state is transient (i.e. not persisted across sessions), I think it may be ok. Thoughts?

(In reply to Mike de Boer [:mikedeboer] from comment #12)
That makes sense to me too. iirc it was even discussed back when we first implemented the page actions. There might even be an open bug. As you say, the fact that this state would be transient probably makes this a lot easier to implement than it would be otherwise. It definitely seems doable.

Which is how we ended up here. Aaron, what are your thoughts on the implementation idea I suggested?

Comment 6

[Dão Gottwald [::dao]]

Attachment: Bug 1401835 - Hide page action buttons in small windows.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c4a4bfa19a9
Hide page action buttons in small windows. r=mak

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8c4a4bfa19a9

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #24882 (as of Fri, 07 Feb 2020 07:11:01 GMT) ==

Improvements:

4% tart linux64-shippable opt e10s stylo 2.15 -> 2.06
4% tart linux64-shippable opt e10s stylo 2.15 -> 2.07

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24882

Comment 10

[Oana Botisan, Desktop Release QA]

I managed to reproduce the issue using an older version of Nightly (2017-09-20).
I retested everything using the latest Nightly 74.0a1 on macOS 10.15, Windows 10 x64 and Ubuntu 18.04 x64. I've noticed that the button for "Toggle Reader View", "Verified by:.." and others are not hidden. Is this expected behaviour?

Comment 11

[Dão Gottwald [::dao]]

(In reply to Oana Botisan, Desktop Release QA from comment #10)

I've noticed that the button for "Toggle Reader View", "Verified by:.." and others are not hidden. Is this expected behaviour?

Yes.

Comment 12

[Oana Botisan, Desktop Release QA]

Thank you, Dao.
According to comment 10 and comment 11, I will mark this bug as verified fixed.