Closed Bug 1401842 Opened 2 years ago Closed 2 years ago

Intermittent js/src/jit-test/tests/debug/bug1370905.js | Timeout (code -9, args "--ion-eager --ion-offthread-compile=off") [150.0 s]

Categories

(Core :: JavaScript Engine: JIT, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr60 --- fixed
firefox61 --- fixed
firefox62 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jonco)

References

Details

(Keywords: intermittent-failure, Whiteboard: [retriggered])

Attachments

(1 file)

Flags: needinfo?(jdemooij)
(In reply to Tiberius Oros[:tiberius_oros] from comment #20)
> At the moment, I believe a good candidate for where the job started to fail
> first is this push:
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-
> inbound&revision=d46b75deaae586798e885c3e61f8efb0bfdb3069&filter-
> searchStr=spidermonkey-sm-compacting-linux64%2Fdebug

It's possible these changes made this just a bit slower so we timeout more frequently. Most of the failures are with the SM(cgc) build but also SM(r) fails sometimes.

It could be the CheckThreadLocal::check changes where we now [0] always MOZ_ASSERT(id == ThisThread::GetId()). However, this test has been timing out intermittently before so we should probably fix the test somehow.

[0] https://hg.mozilla.org/integration/mozilla-inbound/rev/d46b75deaae586798e885c3e61f8efb0bfdb3069#l2.16
Flags: needinfo?(jdemooij) → needinfo?(jcoppeard)
I fiddled with the test and discovered that passing {sameZoneAs: this} to newGlobal() speeded the test up considerably, from 51 seconds to 34 seconds to run all --tbpl variations.

I checked that the test still failed when I commented out the fix for the original bug.
Assignee: nobody → jcoppeard
Flags: needinfo?(jcoppeard)
Attachment #8980255 - Flags: review?(jdemooij)
Comment on attachment 8980255 [details] [diff] [review]
bug1401842-slow-test

Review of attachment 8980255 [details] [diff] [review]:
-----------------------------------------------------------------

Interesting.
Attachment #8980255 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/2836ce086f27
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Flags: needinfo?(jlaster)
See Also: → 1464092
You need to log in before you can comment on or make changes to this bug.