Closed
Bug 1401863
Opened 7 years ago
Closed 7 years ago
Handle the case when gNeckoChild is null in RequestContext properly
Categories
(Core :: Networking: HTTP, enhancement, P2)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: kershaw, Assigned: kershaw)
Details
Attachments
(1 file, 1 obsolete file)
1.24 KB,
patch
|
kershaw
:
review+
|
Details | Diff | Splinter Review |
It is possible that IsNeckoChild returning true and gNeckoChild is null at [1]. If this happens, we should not change |mAfterDOMContentLoaded|. [1] https://searchfox.org/mozilla-central/rev/2ef8bd8a46a02c68ddbb1d5f25fa254dd7be1fbd/netwerk/base/RequestContextService.cpp#111
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → kechang
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•7 years ago
|
||
Summary: - Ensure that |mAfterDOMContentLoaded| won't be changed in child process. Thanks.
Attachment #8912156 -
Flags: review?(honzab.moz)
Comment 2•7 years ago
|
||
Comment on attachment 8912156 [details] [diff] [review] patch Review of attachment 8912156 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #8912156 -
Flags: review?(honzab.moz) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Carry r+.
Attachment #8912156 -
Attachment is obsolete: true
Attachment #8912488 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/67cd96ae5a7d Handle the case when gNeckoChild is null properly in RequestContext::BeginLoad. r=mayhemer
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/67cd96ae5a7d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•