Closed Bug 1401863 Opened 7 years ago Closed 7 years ago

Handle the case when gNeckoChild is null in RequestContext properly

Categories

(Core :: Networking: HTTP, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

Details

Attachments

(1 file, 1 obsolete file)

It is possible that IsNeckoChild returning true and gNeckoChild is null at [1].
If this happens, we should not change |mAfterDOMContentLoaded|.

[1] https://searchfox.org/mozilla-central/rev/2ef8bd8a46a02c68ddbb1d5f25fa254dd7be1fbd/netwerk/base/RequestContextService.cpp#111
Assignee: nobody → kechang
Status: NEW → ASSIGNED
Attached patch patch (obsolete) — Splinter Review
Summary:
 - Ensure that |mAfterDOMContentLoaded| won't be changed in child process.

Thanks.
Attachment #8912156 - Flags: review?(honzab.moz)
Comment on attachment 8912156 [details] [diff] [review]
patch

Review of attachment 8912156 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #8912156 - Flags: review?(honzab.moz) → review+
Carry r+.
Attachment #8912156 - Attachment is obsolete: true
Attachment #8912488 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67cd96ae5a7d
Handle the case when gNeckoChild is null properly in RequestContext::BeginLoad. r=mayhemer
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/67cd96ae5a7d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: