Closed Bug 1401876 Opened 4 years ago Closed 4 years ago

[DateTimePicker] Picker does not close when popup is hidden

Categories

(Core :: Layout: Form Controls, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla58
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: scottwu, Assigned: scottwu)

References

Details

Attachments

(2 files)

The changes introduced in Bug 1390794 caused the picker not closing even when hidden.
Hi Scott, I guess we just need to clean up the resources but don't need to close the picker manually, right?
Thanks Jessica, you are right that hidePopup is redundant in closePicker, but it's still necessary in other places. I've made the change and also added a test to check for picker reopening states.
Comment on attachment 8910639 [details]
Bug 1401876 - (Part 1) Close datetime picker on popuphidden.

https://reviewboard.mozilla.org/r/182082/#review189370
Attachment #8910639 - Flags: review?(mconley) → review+
Comment on attachment 8911726 [details]
Bug 1401876 - (Part 2) Add browser-chrome test for reopening picker.

https://reviewboard.mozilla.org/r/183134/#review189372

Thanks! And thanks for the test!
Comment on attachment 8911726 [details]
Bug 1401876 - (Part 2) Add browser-chrome test for reopening picker.

https://reviewboard.mozilla.org/r/183134/#review189374
Attachment #8911726 - Flags: review?(mconley) → review+
Thanks! Checking it in.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e238860e4943
(Part 1) Close datetime picker on popuphidden. r=mconley
https://hg.mozilla.org/integration/autoland/rev/97ea12f29815
(Part 2) Add browser-chrome test for reopening picker. r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e238860e4943
https://hg.mozilla.org/mozilla-central/rev/97ea12f29815
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Could you also verify this bug for us Emil? It's a patch we'd like to uplift as well.

STR:
1. Open URL `data:text/html,<input type="date"/>`
2. Click the month-year button on the top
3. Click outside of the picker to close it
4. Open the picker again by clicking on the input box

Expected:
The picker should open to a clean state with calendar in view.

Actual:
The picker retains the previous state, showing month and year spinners.

Thanks!
Flags: needinfo?(emil.ghitta)
I have managed to reproduce this issue using Firefox 57.0a1 (BuildId:20170920220431) by following the steps mentioned in comment 12.

This issue is verified fixed on Firefox 58.0a1 (BuildId:20171004220309) using Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.

Leaving my needinfo here as well.

Thank you Scott for the steps!
Status: RESOLVED → VERIFIED
Comment on attachment 8910639 [details]
Bug 1401876 - (Part 1) Close datetime picker on popuphidden.

Approval Request Comment
[Feature/Bug causing the regression]:
Bug 1390794 changed how popup is closed and prevented state from cleaning.
[User impact if declined]:
User could see the UI state from the previous date picker.
[Is this code covered by automated tests?]:
Yes.
[Has the fix been verified in Nightly?]:
Yes.
[Needs manual test from QE? If yes, steps to reproduce]:
Yes. STR as listed on comment 12.
[List of other uplifts needed for the feature/fix]:
Part 2 of this patch: https://bugzilla.mozilla.org/attachment.cgi?id=8911726
[Is the change risky?]:
No.
[Why is the change risky/not risky?]:
Only changes where popup closing is called.
[String changes made/needed]:
No.
Attachment #8910639 - Flags: approval-mozilla-beta?
Comment on attachment 8910639 [details]
Bug 1401876 - (Part 1) Close datetime picker on popuphidden.

Fixing a recent regression in DateTime picker, Beta57+
Attachment #8910639 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
This issue is verified fixed using Firefox 57.0b7 (BuildId:20171009192146) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.
Flags: needinfo?(emil.ghitta)
You need to log in before you can comment on or make changes to this bug.