Closed Bug 1401908 Opened 2 years ago Closed 2 years ago

Clean up text-shadow rules for Dark and Light theme

Categories

(Firefox :: Theme, enhancement, P1)

57 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 57
Iteration:
57.3 - Sep 19
Tracking Status
firefox57 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(1 file)

We seem to currently remove the text-shadow only from some select elements. We should just remove it from the root node instead.
Comment on attachment 8910677 [details]
Bug 1401908 - Completely disable the lightweight theme text-shadow for the Dark and Light themes.

https://reviewboard.mozilla.org/r/182130/#review187474

That makes sense!
Attachment #8910677 - Flags: review?(jhofmann) → review+
Flags: qe-verify-
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b77ab1b8e557
Completely disable the lightweight theme text-shadow for the Dark and Light themes. r=johannh
https://hg.mozilla.org/mozilla-central/rev/b77ab1b8e557
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Iteration: --- → 57.3 - Sep 19
You need to log in before you can comment on or make changes to this bug.