reload button in overflow menu becomes inactive after tab detached from window

VERIFIED FIXED in Firefox 57

Status

()

P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: zalatik, Assigned: Gijs)

Tracking

57 Branch
Firefox 58
Points:
---

Firefox Tracking Flags

(firefox57 verified, firefox58+ verified)

Details

(Whiteboard: [reserve-photon-structure])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170920220431

Steps to reproduce:

1. Open firefox with several tabs open.
2. Pin reload button to overflow menu.
3. Detach a tab to separate window using mouse.


Actual results:

Reload button becomes inactive. It also remains inactive after unpinning from overflow menu.


Expected results:

Reload button remains active.

Updated

2 years ago
Status: UNCONFIRMED → NEW
Has STR: --- → yes
status-firefox57: --- → affected
tracking-firefox57: --- → ?
Component: Untriaged → Toolbars and Customization
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → All
(Assignee)

Comment 1

2 years ago
(In reply to Maxim Zalata from comment #0)
> Reload button becomes inactive. It also remains inactive after unpinning
> from overflow menu.


In the original window, the new window, or both?

Generally, I suspect this is effectively a dupe of bug 1378819, even though the STR are different.
Flags: needinfo?(zalatik)
See Also: → bug 1378819
Whiteboard: [photon-structure][triage]
(Reporter)

Comment 2

2 years ago
Only the new window. Also the button doesn't show 'stop' on page loading as in bug 1378819.
Flags: needinfo?(zalatik)
(Assignee)

Updated

2 years ago
See Also: → bug 1402493
Flags: qe-verify+
Priority: -- → P4
QA Contact: gwimberly
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]
Based on the fact that this was triaged as a P4, I am assuming this won't get fixed in 57. Please correct me if I am wrong. Moved tracking noms to 58.
status-firefox57: affected → wontfix
status-firefox58: --- → affected
tracking-firefox57: ? → ---
tracking-firefox58: --- → ?
(Assignee)

Comment 4

2 years ago
(In reply to Ritu Kothari (:ritu) from comment #3)
> Based on the fact that this was triaged as a P4, I am assuming this won't
> get fixed in 57. Please correct me if I am wrong.

It's unlikely, but we'll take a patch. It's just not a high priority given that:

- customizing the button into the overflow panel is uncommon
- tab detaching is uncommon
- the button now (after bug 1378819) in my testing, at least, the button does start working in the new window/tab as soon as another page load happens.
status-firefox57: wontfix → fix-optional
Comment hidden (mozreview-request)
(Assignee)

Comment 6

2 years ago
Yoink. I tested if bug 1402493 fixed this (it didn't) and then realized fairly quickly what the problem was. X-ref bug 1388990.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Priority: P4 → P1
Comment on attachment 8913628 [details]
Bug 1401943 - make reload button work immediately after a tab detach,

https://reviewboard.mozilla.org/r/185024/#review190128
Attachment #8913628 - Flags: review?(jaws) → review+
Tracking 58+ based on P1 status and comment 6.
tracking-firefox58: ? → +

Comment 9

2 years ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c8bcfa26b552
make reload button work immediately after a tab detach, r=jaws

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c8bcfa26b552
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
(Assignee)

Comment 11

2 years ago
Comment on attachment 8913628 [details]
Bug 1401943 - make reload button work immediately after a tab detach,

Approval Request Comment
[Feature/Bug causing the regression]: we made the reload button movable for photon
[User impact if declined]: in some edgecases it won't be enabled/disabled correctly
[Is this code covered by automated tests?]: there are some basic tests for the behaviour of the button, but nothing specific to this particular bug
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: see comment #0
[List of other uplifts needed for the feature/fix]: bug 1402493 (and bug 1378819, but that's already been uplifted)
[Is the change risky?]: no
[Why is the change risky/not risky?]: this is a very small change that only affects the initialization of the reload/stop buttons and ensuring they're in sync with their respective commands (ie whether refresh/stop are actually available at that point in time) when the window opens.
[String changes made/needed]: nope
Attachment #8913628 - Flags: approval-mozilla-beta?
Comment on attachment 8913628 [details]
Bug 1401943 - make reload button work immediately after a tab detach,

polish photon, taking it.  Should be in 57b5
Attachment #8913628 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox57: fix-optional → affected

Comment 13

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/307f151ecf04
status-firefox57: affected → fixed
Verified with Windows 10 64bit, Mac OS X 10.11, Ubuntu 16.04 64bit using Nightly 58.0a1 (64-bit) as of this date.
status-firefox58: fixed → verified
Reproduced this issue using STR from comment 0, on 57.0a1 (20170921100141).

Verified fixed on 57.0b6 (20171005195903) running Windows 10 x64, Mac OS X 10.11 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.