Closed Bug 1401985 Opened 2 years ago Closed 2 years ago

Purge frontend collection pool after off thread parsing

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 - wontfix
firefox58 --- fixed

People

(Reporter: bhackett, Assigned: bhackett)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Each context has its own frontend collection pool, which is used while parsing.  On cooperative threads this is purged on GC, but on helper threads this does not ever seem to be purged, which can lead to both wasted memory and shutdown hangs (see bug 1401481).  This is a regression from bug 1325050; before that bug, each parse task had its own context, which was destroyed when the parse finished.
Attachment #8910764 - Flags: review?(jcoppeard)
Attachment #8910764 - Flags: review?(jcoppeard) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5382070b3a0d
Purge frontend collection pool after off thread parsing, r=jonco.
https://hg.mozilla.org/mozilla-central/rev/5382070b3a0d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Wasting memory and shutdown hangs, why not uplift this to 57?
Flags: needinfo?(bhackett1024)
Doesn't appear to be a new regression. Bar is high for 57 - we are going to have to won't fix it for that release.
Flags: needinfo?(bhackett1024)
You need to log in before you can comment on or make changes to this bug.