Closed
Bug 1401985
Opened 7 years ago
Closed 7 years ago
Purge frontend collection pool after off thread parsing
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
494 bytes,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
Each context has its own frontend collection pool, which is used while parsing. On cooperative threads this is purged on GC, but on helper threads this does not ever seem to be purged, which can lead to both wasted memory and shutdown hangs (see bug 1401481). This is a regression from bug 1325050; before that bug, each parse task had its own context, which was destroyed when the parse finished.
Attachment #8910764 -
Flags: review?(jcoppeard)
|
||
Updated•7 years ago
|
Attachment #8910764 -
Flags: review?(jcoppeard) → review+
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5382070b3a0d Purge frontend collection pool after off thread parsing, r=jonco.
|
||
Comment 2•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5382070b3a0d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•7 years ago
|
status-firefox57:
affected → ---
|
||
Comment 3•7 years ago
|
||
Wasting memory and shutdown hangs, why not uplift this to 57?
|
||
Comment 4•7 years ago
|
||
Doesn't appear to be a new regression. Bar is high for 57 - we are going to have to won't fix it for that release.
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(bhackett1024)
You need to log in
before you can comment on or make changes to this bug.
Description
•