Closed
Bug 1402006
Opened 7 years ago
Closed 7 years ago
C++ bustage in libical: calendar/libical/src/libical/icaltimezone.c:45:25: fatal error: icaltz-util.h: No such file or directory
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 58.0
People
(Reporter: jorgk-bmo, Assigned: tomprince)
Details
Attachments
(1 file, 1 obsolete file)
742 bytes,
patch
|
Details | Diff | Splinter Review |
Different platform show different errors: Linux: /builds/slave/tb-c-cen-l64-00000000000000000/build/calendar/libical/src/libical/icaltimezone.c:45:25: fatal error: icaltz-util.h: No such file or directory Mac: /builds/slave/tb-c-cen-m64-00000000000000000/build/calendar/libical/src/libical/icaltimezone.c:45:10: fatal error: 'icaltz-util.h' file not found [log…] Windows: c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/calendar/libical/src/libical/icalparameter.c(54): error C2054: expected '(' to follow 'va_dcl' [log…] c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/calendar/libical/src/libical/icalparameter.c(54): error C2082: redefinition of formal parameter 'icalparameter_new_from_value_string' [log…] c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/calendar/libical/src/libical/icalparameter.c(58): error C2085: 'icalparameter_new_impl': not in formal parameter list [log…] c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/calendar/libical/src/libical/icalparameter.c(58): error C2143: syntax error: missing ';' before '{' [log…]
Reporter | ||
Comment 1•7 years ago
|
||
icaltimezone.c:45 reads: #ifndef NO_ZONES_TAB #include "icaltz-util.h" <=== 45 #endif That file indeed doesn't exist. I have to check what change in M-C. Last good: 47f7b6c64265 First bad: 835a92b19e3d https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=47f7b6c64265&tochange=835a92b19e3d
Reporter | ||
Comment 2•7 years ago
|
||
The compile fails since config.h is not included, which is controlled by: #ifdef HAVE_CONFIG_H #include "config.h" #endif And that's controlled by the makefile: https://dxr.mozilla.org/comm-central/source/calendar/libical/src/libical/Makefile.in#38 DEFINES += -DHAVE_CONFIG_H DEFINES += -DHAVE_SNPRINTF But somehow that's not effective. :-(
Reporter | ||
Comment 3•7 years ago
|
||
Talked to Tom on IRC, he suggested bug 1398897 and gave me a fix. So I'm trying that now.
Reporter | ||
Comment 4•7 years ago
|
||
Reporter | ||
Comment 5•7 years ago
|
||
Attachment #8910948 -
Attachment is obsolete: true
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/153b971fbc21 Port bug 1398897 to libical: repeat defines from Makefile.in in moz.build. r=jorgk
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 7•7 years ago
|
||
Thanks, Tom!
Assignee: nobody → mozilla
Target Milestone: --- → Thunderbird 58.0
You need to log in
before you can comment on or make changes to this bug.
Description
•