Closed
Bug 1402015
Opened 7 years ago
Closed 7 years ago
Submit re-compressed MAR metadata to Balrog
Categories
(Release Engineering :: Release Automation: Other, enhancement, P1)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(8 files, 7 obsolete files)
|
59 bytes,
text/x-review-board-request
|
sfraser
:
review+
rail
:
checked-in+
|
Details |
|
4.73 KB,
patch
|
sfraser
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
|
961 bytes,
patch
|
mozilla
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
|
1.54 KB,
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
|
1.54 KB,
patch
|
mozilla
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
|
59 bytes,
text/x-review-board-request
|
sfraser
:
review+
rail
:
checked-in+
|
Details |
|
5.47 KB,
patch
|
sfraser
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
|
55 bytes,
text/x-github-pull-request
|
jlorenzo
:
review+
rail
:
checked-in+
|
Details | Review |
In bug 1395697 we generate and beetmove complete MARs, but do not submit their metadata to balrog. The existing script https://dxr.mozilla.org/mozilla-central/source/taskcluster/docker/funsize-balrog-submitter/scripts/funsize-balrog-submitter.py has some assumptions, so we need something similar but for completes-only. The release blob names also should be different (suffix="-bz2").
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
|
Assignee | |
Comment 3•7 years ago
|
||
The patches "should just work", but better to test them first. Probably with other ones.
|
|
Assignee | |
Comment 4•7 years ago
|
||
Attachment #8912306 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•7 years ago
|
||
Attachment #8912305 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•7 years ago
|
||
These should cover bug 1402020 as well
|
|
Assignee | |
Comment 7•7 years ago
|
||
Attachment #8912317 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 8•7 years ago
|
||
Attachment #8912316 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 9•7 years ago
|
||
|
|
Assignee | |
Comment 10•7 years ago
|
||
Hopefully this is all we need. Now I need to test this in staging!
| Comment hidden (mozreview-request) |
|
||
Comment 12•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8914356 [details] Bug 1402015 - Override Balrog blob name suffix, MAR filename pattern, Bouncer product name pattern https://reviewboard.mozilla.org/r/185620/#review190626
Attachment #8914356 -
Flags: review?(sfraser) → review+
|
|
Assignee | |
Comment 13•7 years ago
|
||
Comment on attachment 8914356 [details] Bug 1402015 - Override Balrog blob name suffix, MAR filename pattern, Bouncer product name pattern https://hg.mozilla.org/build/tools/rev/a2ecd77a1ee12e13521371ac4dcfe02eab7bb62c
Attachment #8914356 -
Flags: checked-in+
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8912887 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 14•7 years ago
|
||
Apparently we don't want to override the "from" suffix, because by default we don't want to use the same suffix. We will be generating 2 blobs, with and without suffix, but the latter is preferable. Also we didn't use the suffix in the past.
Attachment #8914496 -
Flags: review?(sfraser)
|
|
Assignee | |
Comment 15•7 years ago
|
||
We don't want to None to be converted to "None".
Attachment #8914512 -
Flags: review?(aki)
|
||
Updated•7 years ago
|
Attachment #8914512 -
Flags: review?(aki) → review+
|
|
Assignee | |
Comment 16•7 years ago
|
||
Comment on attachment 8914512 [details] [diff] [review] tools: do not use "None" for explicit None https://hg.mozilla.org/users/raliiev_mozilla.com/tools/rev/d3515de6e5856b442aa4d8f133be7d3d3ffe5960
Attachment #8914512 -
Flags: checked-in+
|
|
||
Updated•7 years ago
|
Attachment #8914496 -
Flags: review?(sfraser) → review+
|
|
Assignee | |
Comment 17•7 years ago
|
||
Comment on attachment 8914496 [details] [diff] [review] tools: override fromsuffix https://hg.mozilla.org/build/tools/rev/23c067a6cffdbac3f635c901d0703f16080faaf3
Attachment #8914496 -
Flags: checked-in+
|
||
Updated•7 years ago
|
Attachment #8914895 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Comment 19•7 years ago
|
||
Comment on attachment 8914895 [details] [diff] [review] ReleaseSubmitterBase.diff https://hg.mozilla.org/build/tools/rev/912affa82eefd92956925603c3c735b944eee94a
Attachment #8914895 -
Flags: checked-in+
|
|
Assignee | |
Comment 20•7 years ago
|
||
Attachment #8915047 -
Flags: review?(aki)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8912884 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8912885 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 22•7 years ago
|
||
Passing --suffix -bz2 is a PITA!!!
Attachment #8915135 -
Flags: review?(sfraser)
|
|
Assignee | |
Comment 23•7 years ago
|
||
Attachment #8915139 -
Flags: review?(jlorenzo)
|
|
||
Comment 24•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8915134 [details] Bug 1402015 - Submit re-compressed MAR metadata to Balrog https://reviewboard.mozilla.org/r/186384/#review191464
Attachment #8915134 -
Flags: review?(sfraser) → review+
|
|
||
Updated•7 years ago
|
Attachment #8915135 -
Flags: review?(sfraser) → review+
|
|
||
Comment 25•7 years ago
|
||
Comment on attachment 8915047 [details] [diff] [review] mar_tools.diff Oops, sorry for the delay!
Attachment #8915047 -
Flags: review?(aki) → review+
|
||
Comment 26•7 years ago
|
||
Comment on attachment 8915139 [details] [review] PR for releasetask Sorry for the delay. LGTM
Attachment #8915139 -
Flags: review?(jlorenzo) → review+
|
|
Assignee | |
Comment 27•7 years ago
|
||
Comment on attachment 8915047 [details] [diff] [review] mar_tools.diff https://hg.mozilla.org/build/tools/rev/22370bd56558082ef541d7a5a80384932a8a2c5c
Attachment #8915047 -
Flags: checked-in+
|
|
Assignee | |
Comment 28•7 years ago
|
||
Comment on attachment 8915135 [details] [diff] [review] tools_no_suffix.diff https://hg.mozilla.org/build/tools/rev/530d180bb60b300d09c23ca128261cad06d50c78
Attachment #8915135 -
Flags: checked-in+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: leave-open
|
||
Comment 29•7 years ago
|
||
Pushed by raliiev@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/70b3fb79bc92 Submit re-compressed MAR metadata to Balrog r=sfraser a=release DONTBUILD
|
|
Assignee | |
Comment 30•7 years ago
|
||
Comment on attachment 8915134 [details] Bug 1402015 - Submit re-compressed MAR metadata to Balrog https://hg.mozilla.org/integration/mozilla-inbound/rev/70b3fb79bc92e26af03c2cf16445975b30346781
Attachment #8915134 -
Flags: checked-in+
|
|
Assignee | |
Comment 31•7 years ago
|
||
I tried to push this to beta, but the decision task failed: https://tools.taskcluster.net/groups/XugxWvNaRFOf3SR1hJHlsg/tasks/XugxWvNaRFOf3SR1hJHlsg/runs/0/logs/public%2Flogs%2Flive.log We need to uplift something under taskcluster/ to make it work.
|
|
Assignee | |
Comment 32•7 years ago
|
||
Probably https://hg.mozilla.org/mozilla-central/rev/79bb52091750#l2.394 is missing. Not sure how safe it would be to uplift this though.
|
||
Comment 33•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/70b3fb79bc92
|
|
Assignee | |
Comment 34•7 years ago
|
||
Take 2 on beta: https://hg.mozilla.org/releases/mozilla-beta/rev/7e991d4124cd3c10d3b8d87d55eeed8d1b4e522f
|
|
Assignee | |
Comment 35•7 years ago
|
||
and release: https://hg.mozilla.org/releases/mozilla-release/rev/6791d67e93ad85502df8ec4e216505b3c63d5f8a
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8915139 -
Flags: checked-in+
|
|
Assignee | |
Comment 36•7 years ago
|
||
Landed/deployed all the things. I'll keep an eye on it tomorrow.
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 37•7 years ago
|
||
Somehow the patch was backed out in https://hg.mozilla.org/mozilla-central/rev/32faa962a605 O_O
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 38•7 years ago
|
||
Looks like a bad conflict resolution in https://hg.mozilla.org/mozilla-central/rev/3f30519845d3
|
|
||
Comment 39•7 years ago
|
||
Pushed by raliiev@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/aebba462abec Submit re-compressed MAR metadata to Balrog. Fix bad merge. r=me a=release DONTBUILD
|
|
Assignee | |
Updated•7 years ago
|
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
|
||
Comment 40•6 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•