Submit re-compressed MAR metadata to Balrog

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(8 attachments, 7 obsolete attachments)

59 bytes, text/x-review-board-request
sfraser
: review+
Details
4.73 KB, patch
sfraser
: review+
Details | Diff | Splinter Review
961 bytes, patch
aki
: review+
Details | Diff | Splinter Review
1.54 KB, patch
bhearsum
: review+
Details | Diff | Splinter Review
1.54 KB, patch
aki
: review+
Details | Diff | Splinter Review
59 bytes, text/x-review-board-request
sfraser
: review+
Details
5.47 KB, patch
sfraser
: review+
Details | Diff | Splinter Review
55 bytes, text/x-github-pull-request
jlorenzo
: review+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
In bug 1395697 we generate and beetmove complete MARs, but do not submit their metadata to balrog.

The existing script https://dxr.mozilla.org/mozilla-central/source/taskcluster/docker/funsize-balrog-submitter/scripts/funsize-balrog-submitter.py has some assumptions, so we need something similar but for completes-only. The release blob names also should be different (suffix="-bz2").
(Assignee)

Comment 1

2 years ago
Posted patch WIP gecko patch (obsolete) — Splinter Review
(Assignee)

Comment 2

2 years ago
Posted patch WIP releasetasks patch (obsolete) — Splinter Review
(Assignee)

Comment 3

2 years ago
The patches "should just work", but better to test them first. Probably with other ones.
(Assignee)

Comment 4

2 years ago
Posted patch WIP releasetasks patch (obsolete) — Splinter Review
Attachment #8912306 - Attachment is obsolete: true
(Assignee)

Comment 5

2 years ago
Posted patch WIP gecko patch (obsolete) — Splinter Review
Attachment #8912305 - Attachment is obsolete: true
(Assignee)

Comment 6

2 years ago
These should cover bug 1402020 as well
(Assignee)

Comment 7

2 years ago
Posted patch gecko.diff (obsolete) — Splinter Review
Attachment #8912317 - Attachment is obsolete: true
(Assignee)

Comment 8

2 years ago
Posted patch releasetasks.diff (obsolete) — Splinter Review
Attachment #8912316 - Attachment is obsolete: true
(Assignee)

Comment 9

2 years ago
Posted patch tools.diff (obsolete) — Splinter Review
(Assignee)

Comment 10

2 years ago
Hopefully this is all we need. Now I need to test this in staging!

Comment 12

2 years ago
mozreview-review
Comment on attachment 8914356 [details]
Bug 1402015 - Override Balrog blob name suffix, MAR filename pattern, Bouncer product name pattern

https://reviewboard.mozilla.org/r/185620/#review190626
Attachment #8914356 - Flags: review?(sfraser) → review+
(Assignee)

Comment 13

2 years ago
Comment on attachment 8914356 [details]
Bug 1402015 - Override Balrog blob name suffix, MAR filename pattern, Bouncer product name pattern

https://hg.mozilla.org/build/tools/rev/a2ecd77a1ee12e13521371ac4dcfe02eab7bb62c
Attachment #8914356 - Flags: checked-in+
(Assignee)

Updated

2 years ago
Attachment #8912887 - Attachment is obsolete: true
(Assignee)

Comment 14

2 years ago
Apparently we don't want to override the "from" suffix, because by default we don't want to use the same suffix. We will be generating 2 blobs, with and without suffix, but the latter is preferable. Also we didn't use the suffix in the past.
Attachment #8914496 - Flags: review?(sfraser)
(Assignee)

Comment 15

2 years ago
We don't want to None to be converted to "None".
Attachment #8914512 - Flags: review?(aki)

Updated

2 years ago
Attachment #8914512 - Flags: review?(aki) → review+
Attachment #8914496 - Flags: review?(sfraser) → review+
(Assignee)

Comment 18

2 years ago
Mixins!!!
Attachment #8914895 - Flags: review?(bhearsum)
Attachment #8914895 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 20

2 years ago
Attachment #8915047 - Flags: review?(aki)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8912884 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8912885 - Attachment is obsolete: true
(Assignee)

Comment 22

2 years ago
Passing --suffix -bz2 is a PITA!!!
Attachment #8915135 - Flags: review?(sfraser)
(Assignee)

Comment 23

2 years ago
Posted file PR for releasetask
Attachment #8915139 - Flags: review?(jlorenzo)

Comment 24

2 years ago
mozreview-review
Comment on attachment 8915134 [details]
Bug 1402015 - Submit re-compressed MAR metadata to Balrog

https://reviewboard.mozilla.org/r/186384/#review191464
Attachment #8915134 - Flags: review?(sfraser) → review+
Attachment #8915135 - Flags: review?(sfraser) → review+
Comment on attachment 8915047 [details] [diff] [review]
mar_tools.diff

Oops, sorry for the delay!
Attachment #8915047 - Flags: review?(aki) → review+
Comment on attachment 8915139 [details] [review]
PR for releasetask

Sorry for the delay. LGTM
Attachment #8915139 - Flags: review?(jlorenzo) → review+
(Assignee)

Updated

2 years ago
Keywords: leave-open

Comment 29

2 years ago
Pushed by raliiev@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70b3fb79bc92
Submit re-compressed MAR metadata to Balrog r=sfraser a=release DONTBUILD
(Assignee)

Comment 31

2 years ago
I tried to push this to beta, but the decision task failed: https://tools.taskcluster.net/groups/XugxWvNaRFOf3SR1hJHlsg/tasks/XugxWvNaRFOf3SR1hJHlsg/runs/0/logs/public%2Flogs%2Flive.log

We need to uplift something under taskcluster/ to make it work.
(Assignee)

Comment 32

2 years ago
Probably https://hg.mozilla.org/mozilla-central/rev/79bb52091750#l2.394 is missing. Not sure how safe it would be to uplift this though.
(Assignee)

Updated

2 years ago
Depends on: 1407279
(Assignee)

Updated

2 years ago
Attachment #8915139 - Flags: checked-in+
(Assignee)

Comment 36

2 years ago
Landed/deployed all the things. I'll keep an eye on it tomorrow.
(Assignee)

Updated

a year ago
See Also: → bug 1411981
(Assignee)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Comment 37

a year ago
Somehow the patch was backed out in https://hg.mozilla.org/mozilla-central/rev/32faa962a605 O_O
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 38

a year ago
Looks like a bad conflict resolution in https://hg.mozilla.org/mozilla-central/rev/3f30519845d3

Comment 39

a year ago
Pushed by raliiev@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/aebba462abec
Submit re-compressed MAR metadata to Balrog. Fix bad merge. r=me a=release DONTBUILD
(Assignee)

Updated

a year ago
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.