1402043 - MatchPattern subsumption checks mishandle *://

Status: NEW

(WebExtensions :: General, enhancement, P3)

Description

[Ian Moody [:Kwan] (UTC+0)]

let matcher = new MatchPatternSet(["http://*.example.com/*", "https://*.example.com/*"]);
let newPerm = new MatchPattern("*://*.example.com/*");
matcher.subsumes(newPerm); // false

This should return true from reading the docs since https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Match_patterns#scheme specifies that *:// matches only http:// and https://

...however looking at the code the docs are out of date, and ws: and wss: should be listed since https://hg.mozilla.org/mozilla-central/rev/62e44a827308 and bug 1367478.  Though even adjusting the code to include websockets still gives an incorrect false:

let wsMatcher = new MatchPatternSet(["http://*.example.com/*", "https://*.example.com/*", "ws://*.example.com/*", "wss://*.example.com/*"]);
wsMatcher.subsumes(newPerm); // false

overlapsAll also seems to give incorrect results:

matcher.overlapsAll(new MatchPatternSet(["*://*.example.com/*"])); // true
// should be false since matcher is missing wss?://

it's possible I'm misunderstanding the code somewhere

Comment 1

[Andy McKay]

Looks like the docs need fixing up, added flag. ni'ing mixedpuppy for the rest.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Pretty much as Kris updated. ws/s is somewhat of an alias to http/s, we're treating it as such for pattern matching.

Comment 3

[Chris Mills [:cmills]]

Looks like the docs have been fixed since then, to cover ws/wss