1402056 - Onboarding: Firefox Notification Icon on New Tab Not Marked as Read When Tour Complete

Status: NEW

(Firefox :: General, defect, P5)

Description

[Alex Davis [:adavis]]

Per the slack conversation in onboarding channel:

I finished the onboarding tour and had green checkmarks everywhere but the notification incon never turned gray.

Only clicking skip tour resolved it.

Nicole Yee confirmed she could reproduce it too.

Apparently this should not be happening.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thanks for filing. It happened to me too. I realized this is a side effect of our landing order: if an user has visited all the tours before bug 1392475 (?) lands, the overall state will not flip to watermark when it lands.

We'll need to investigate if this impacts beta/early-beta users and do something about it accordingly.

Comment 2

[[e-mail]]

I think this does not effect v56 user or v57 beta user since the tourset is changed when devEdition or beta get the version update.

It only effect v57 nightly user who completed all tours without check the old `hide all tours` checkbox before before bug 1392475, but it can be easily resolved by clicking the `skip tour` button.

Comment 3

[[e-mail]]

FYR, when tourset version get update(in this case is v56 -> v57), we will show the fox icon instead of watermark, and display the new tourset when user click the icon. So this issue does not effect beta or release user for now.

It looks not like an urgent issue, though the fact that we didn't always check all of tours complete state at run time might still cause issue in the future. when:

1. User completed all update user tours and see the watermark
2. we update the tourset version to 3
3. we only change the new tourset but keep the same update tourset.

Now the onboarding will show the Fox icon and update tourset, but all tours are still completed.

And the above fix could be simple: document that we only update the tourset version when we have different **update** tourset. The new tourset update does not require the tourset version update.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Flipping flags according to comment 2 above. Recommending P5 -- to confirm in triage.

Comment 3 looks unrelated to me. Please file another bug to update the document in the source tree if needed.