Closed
Bug 1402126
Opened 6 years ago
Closed 6 years ago
Downloads subview in Library has icons that are too small
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Firefox
Toolbars and Customization
Tracking
()
VERIFIED
FIXED
Firefox 58
People
(Reporter: Dolske, Assigned: mikedeboer)
References
Details
(Whiteboard: [reserve-photon-structure])
Attachments
(3 files)
68.02 KB,
image/png
|
Details | |
60.24 KB,
image/png
|
Details | |
59 bytes,
text/x-review-board-request
|
Gijs
:
review+
ritu
:
approval-mozilla-beta+
|
Details |
The icons in the Downloads subview are too small. Looks like something isn't applying the display scaling? (Current Nightly, Retina display, OSX)
Reporter | ||
Comment 1•6 years ago
|
||
Notice that the icons are the expected size in the downloads button panel (non-Library view).
Assignee | ||
Comment 2•6 years ago
|
||
This is in fact the intended size/ design, but we may revisit this since Aaron mentioned making these icons larger as well.
Updated•6 years ago
|
Flags: needinfo?(abenson)
Updated•6 years ago
|
status-firefox57:
--- → fix-optional
Updated•6 years ago
|
status-firefox57:
fix-optional → ---
Flags: qe-verify+
Priority: -- → P3
QA Contact: gwimberly
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]
Comment 3•6 years ago
|
||
Behold, the embiggened icons: https://mozilla.invisionapp.com/share/A2DOBNQJE#/255377231_Menus_Downloads_Bigger_Icons
Flags: needinfo?(abenson)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment hidden (mozreview-request) |
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8915634 [details] Bug 1402126 - Change the icon size of Download items in the Library's Downloads panel view to 32px. https://reviewboard.mozilla.org/r/186824/#review192686 Can't see the spec, but this looks reasonable enough to me.
Attachment #8915634 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mdeboer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a1188a2bf9ee Change the icon size of Download items in the Library's Downloads panel view to 32px. r=Gijs
![]() |
||
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a1188a2bf9ee
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Assignee | ||
Comment 8•6 years ago
|
||
Since this is a quite simple CSS change, do we want to uplift this to 57?
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(abenson)
Comment 9•6 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #8) > Since this is a quite simple CSS change, do we want to uplift this to 57? Probably, yeah.
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 10•6 years ago
|
||
[Tracking Requested - why for this release]: This panel will be introduced in Fx 57 and this update to larger icons will ship in 58 for sure. It'd be nice to ship a consistent panel view _starting_ with 57 and not introduce a visual change like this one version later.
status-firefox57:
--- → affected
tracking-firefox57:
--- → ?
Comment 11•6 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #8) > Since this is a quite simple CSS change, do we want to uplift this to 57? Yes, that would be ideal.
Flags: needinfo?(abenson)
Assignee | ||
Comment 12•6 years ago
|
||
Comment on attachment 8915634 [details] Bug 1402126 - Change the icon size of Download items in the Library's Downloads panel view to 32px. Approval Request Comment [Feature/Bug causing the regression]: This panel will be introduced in Fx 57 and this update to larger icons will ship in 58 for sure. It'd be nice to ship a consistent panel view _starting_ with 57 and not introduce a visual change like this one version later. [User impact if declined]: Icons are too small in the Downloads subview. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: No. [Needs manual test from QE? If yes, steps to reproduce]: Yes, the icons in the Downloads subview inside the Library should appear double the current size, compared to 57. [List of other uplifts needed for the feature/fix]: n/a. [Is the change risky?]: Minor risk. [Why is the change risky/not risky?]: This is a graphical CSS-only change that is contained to this view. [String changes made/needed]: n/a.
Attachment #8915634 -
Flags: approval-mozilla-beta?
Comment on attachment 8915634 [details] Bug 1402126 - Change the icon size of Download items in the Library's Downloads panel view to 32px. Photon polish, beta57+
Attachment #8915634 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•6 years ago
|
Comment 14•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/63c9ad5b7e93
Comment 15•6 years ago
|
||
Reproduced this issue on affected Nightly build 57.0a1 (2017-09-22). Verified fixed on latest Nightly 58.0a1 (2017-10-13) and Beta 57.0b8 (20171013042429) across platforms: Windows 10 x64, Mac OS X 10.13 and Ubuntu 16.04 x64.
You need to log in
before you can comment on or make changes to this bug.
Description
•