1402126 - Downloads subview in Library has icons that are too small

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Justin Dolske [:Dolske]]

Attachment: Screenshot

The icons in the Downloads subview are too small. Looks like something isn't applying the display scaling? (Current Nightly, Retina display, OSX)

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Screenshot, downloads button

Notice that the icons are the expected size in the downloads button panel (non-Library view).

Comment 2

[Mike de Boer [:mikedeboer]]

This is in fact the intended size/ design, but we may revisit this since Aaron mentioned making these icons larger as well.

Comment 3

[Aaron Benson]

Behold, the embiggened icons: https://mozilla.invisionapp.com/share/A2DOBNQJE#/255377231_Menus_Downloads_Bigger_Icons

Comment 4

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1402126 - Change the icon size of Download items in the Library's Downloads panel view to 32px.

Review commit: https://reviewboard.mozilla.org/r/186824/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186824/

Comment 5

[:Gijs (he/him)]

Comment on attachment 8915634 [details]
Bug 1402126 - Change the icon size of Download items in the Library's Downloads panel view to 32px.

https://reviewboard.mozilla.org/r/186824/#review192686

Can't see the spec, but this looks reasonable enough to me.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1188a2bf9ee
Change the icon size of Download items in the Library's Downloads panel view to 32px. r=Gijs

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a1188a2bf9ee

Comment 8

[Mike de Boer [:mikedeboer]]

Since this is a quite simple CSS change, do we want to uplift this to 57?

Comment 9

[:Gijs (he/him)]

(In reply to Mike de Boer [:mikedeboer] from comment #8)
> Since this is a quite simple CSS change, do we want to uplift this to 57?

Probably, yeah.

Comment 10

[Mike de Boer [:mikedeboer]]

[Tracking Requested - why for this release]: This panel will be introduced in Fx 57 and this update to larger icons will ship in 58 for sure. It'd be nice to ship a consistent panel view _starting_ with 57 and not introduce a visual change like this one version later.

Comment 11

[Aaron Benson]

(In reply to Mike de Boer [:mikedeboer] from comment #8)
> Since this is a quite simple CSS change, do we want to uplift this to 57?

Yes, that would be ideal.

Comment 12

[Mike de Boer [:mikedeboer]]

Comment on attachment 8915634 [details]
Bug 1402126 - Change the icon size of Download items in the Library's Downloads panel view to 32px.

Approval Request Comment
[Feature/Bug causing the regression]: This panel will be introduced in Fx 57 and this update to larger icons will ship in 58 for sure. It'd be nice to ship a consistent panel view _starting_ with 57 and not introduce a visual change like this one version later.
[User impact if declined]: Icons are too small in the Downloads subview.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: No.
[Needs manual test from QE? If yes, steps to reproduce]: Yes, the icons in the Downloads subview inside the Library should appear double the current size, compared to 57.
[List of other uplifts needed for the feature/fix]: n/a.
[Is the change risky?]: Minor risk.
[Why is the change risky/not risky?]: This is a graphical CSS-only change that is contained to this view.
[String changes made/needed]: n/a.

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8915634 [details]
Bug 1402126 - Change the icon size of Download items in the Library's Downloads panel view to 32px.

Photon polish, beta57+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/63c9ad5b7e93

Comment 15

[Stefan [:StefanG_QA]]

Reproduced this issue on affected Nightly build 57.0a1 (2017-09-22).

Verified fixed on latest Nightly 58.0a1 (2017-10-13) and Beta 57.0b8 (20171013042429) across platforms: Windows 10 x64, Mac OS X 10.13 and Ubuntu 16.04 x64.