Closed Bug 1402140 Opened 7 years ago Closed 7 years ago

Ignore PNG eXIf chunk

Categories

(Core :: Graphics: ImageLib, enhancement, P3)

Product:
Core
Component:
Graphics: ImageLib
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: glennrp+bmo, Assigned: glennrp+bmo)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

v00-1402140-ignore-PNG-eXIf-chunk
1.11 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
The PNG eXIf chunk was added recently.  We don't use it, so we should ignore it (the in-tree library already ignores it, but the system library will decode it unless it appears in the "unused_chunks" list in nsPNGDecoder.cpp
Assignee: nobody → glennrp+bmo
Depends on: 1377118
Please "try" this patch.
Flags: needinfo?(ryanvm)
Status: NEW → ASSIGNED
status-firefox57: --- → wontfix
Priority: -- → P3
Whiteboard: [gfx-noted]
Comment on attachment 8910963 [details] [diff] [review]
v00-1402140-ignore-PNG-eXIf-chunk

Try was OK.  R?
Attachment #8910963 - Flags: review?(jmuizelaar)
Attachment #8910963 - Flags: review?(jmuizelaar) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/696af77b0e06
Add "eXIf" to unused_chunks list in PNG decoder. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/696af77b0e06
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: