1402143 - re-enable nth-index-cache style-perf-tests

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Bobby Holley (:bholley)]

In bug 1374750 comment 58, we disabled these because they were too slow (since we didn't have the optimization that was being tested).

When bug 1334730 lands, they should be fast, and we should re-enable them.

Comment 1

[Bobby Holley (:bholley)]

NI to get prioritized.

Comment 2

[Robert Wood [:rwood]]

Awesome! In Bug 1398193 I am landing them as part of the perf-reftest suite.

I'll make a separate patch (with this bug) for adding them in the perf-reftest-singletons suite.

Comment 3

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8f36cb66fbfbec2694fa2e3b73d170c0e079200

Comment 4

[Robert Wood [:rwood]]

Attachment: Bug 1402143 - Re-enable nth-index-cache style-perf singleton tests;

Review commit: https://reviewboard.mozilla.org/r/185052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185052/

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8913661 [details]
Bug 1402143 - Re-enable nth-index-cache style-perf singleton tests;

https://reviewboard.mozilla.org/r/185052/#review190110

glad it is this easy

Comment 6

[Robert Wood [:rwood]]

Thanks, looking good on try, the additional tests add about 1-2 min to the suite which is fine.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8f36cb66fbfbec2694fa2e3b73d170c0e079200

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f781d6ffe5e4
Re-enable nth-index-cache style-perf singleton tests; r=jmaher

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f781d6ffe5e4

Comment 9

[Ionuț Goldan [:igoldan]]

This updated the baseline for perf_reftest_singletons:

== Change summary for alert #9744 (as of September 29 2017 14:59 UTC) ==

Improvements:

 13%  perf_reftest_singletons summary windows7-32 pgo e10s     25.80 -> 22.45
 13%  perf_reftest_singletons summary windows7-32 opt e10s     29.97 -> 26.15
 10%  perf_reftest_singletons summary osx-10-10 opt e10s       28.11 -> 25.38
  9%  perf_reftest_singletons summary linux64 opt e10s         27.29 -> 24.88
  9%  perf_reftest_singletons summary windows10-64 opt e10s    27.88 -> 25.46
  8%  perf_reftest_singletons summary windows10-64 pgo e10s    25.37 -> 23.40
  7%  perf_reftest_singletons summary linux64 pgo e10s         24.72 -> 23.03

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=9744