Closed Bug 1402153 Opened 2 years ago Closed 2 years ago

Remove dead code from the crash reporting machinery

Categories

(Toolkit :: Crash Reporting, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

Attachments

(1 file)

While working nsExceptionHandler.* I've noticed we have quite a bit of dead code in there, let's get rid of it.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
The patch is just stripping out some unused stuff, the try run is here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f4a787a9e8830700d7d5ced4829d06a9ac00a97
I've updated the patch making a lot more non-public functions static. Not a big deal but let's be nice to our linker, it will also be easier to spot if we don't use them anymore so we don't leave more dead code in there.
Comment on attachment 8910976 [details]
Bug 1402153 - Remove dead code from the crash reporter; .mielczarek

https://reviewboard.mozilla.org/r/182444/#review199606
Attachment #8910976 - Flags: review?(ted) → review+
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b5154ab31fc
Remove dead code from the crash reporter; r=ted.mielczarek
https://hg.mozilla.org/mozilla-central/rev/5b5154ab31fc
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.