Closed Bug 1402180 Opened 7 years ago Closed 7 years ago

Remove nsIDOMHTMLAreaElement

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: qdot, Assigned: qdot)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

More XPCOM janitorial work.
Attachment #8912394 - Flags: review?(bzbarsky)
Comment on attachment 8912394 [details]
Bug 1402180 - Remove nsIDOMHTMLAreaElement;

https://reviewboard.mozilla.org/r/183716/#review189518

r=me

::: accessible/html/HTMLImageMapAccessible.cpp:171
(Diff revision 2)
>  HTMLAreaAccessible::Description(nsString& aDescription)
>  {
>    aDescription.Truncate();
>  
>    // Still to do - follow IE's standard here
> -  nsCOMPtr<nsIDOMHTMLAreaElement> area(do_QueryInterface(mContent));
> +  RefPtr<HTMLAreaElement> area = HTMLAreaElement::FromContent(mContent);

FromContent, or FromContentOrNull?  Is mContent guaranteed non-null?

::: dom/html/HTMLAreaElement.h:96
(Diff revision 2)
> +  {
> +    GetURIAttr(nsGkAtoms::href, nullptr, aValue);
> +  }
>    void SetHref(const nsAString& aHref, ErrorResult& aError)
>    {
> -    aError = SetHref(aHref);
> +    SetAttrHelper(nsGkAtoms::href, aHref);

This used to propagate exceptions out; now it does not.

You probably want to assign the return value to aError.  Or just use SetHTMLAttr instead of SetAttrHelper.

::: dom/html/HTMLAreaElement.h:139
(Diff revision 2)
>  
>    void SetReferrerPolicy(const nsAString& aValue, mozilla::ErrorResult& rv)
>    {
>      SetHTMLAttr(nsGkAtoms::referrerpolicy, aValue, rv);
>    }
> -  void GetReferrerPolicy(nsAString& aReferrer)
> +  void GetReferrerPolicy(DOMString& aReferrer)

Not much point to DOMString here, because GetEnumAttr only does nsAString anyway.  Might as well keep it as nsAString.
Attachment #8912394 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/4930e4c3462b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: