1402203 - Add a new layout phase for displaylist building

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: layout-phase

Invalidating frames during display list building causes problems with retained display lists, so we added a new layout phase to let us assert against this.

Comment 1

[Markus Stange [:mstange]]

Comment on attachment 8911025 [details] [diff] [review]
layout-phase

Review of attachment 8911025 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/painting/nsDisplayList.cpp
@@ +1218,5 @@
>    state->mCaretFrame = nullptr;
>    state->mFirstFrameMarkedForDisplay = mFramesMarkedForDisplay.Length();
>  
> +#ifdef DEBUG
> +  state->mAutoLayoutPhase.emplace(aReferenceFrame->PresContext(), eLayoutPhase_DisplayListBuilding);                                                                                

lots of end-of-line whitespace here

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df95a1b7d718
Add a new layout phase for displaylist building. r=mstange

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/df95a1b7d718