Closed Bug 1402203 Opened 5 years ago Closed 5 years ago

Add a new layout phase for displaylist building

Categories

(Core :: Layout, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

Attached patch layout-phaseSplinter Review
Invalidating frames during display list building causes problems with retained display lists, so we added a new layout phase to let us assert against this.
Attachment #8911025 - Flags: review?(mstange)
Comment on attachment 8911025 [details] [diff] [review]
layout-phase

Review of attachment 8911025 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/painting/nsDisplayList.cpp
@@ +1218,5 @@
>    state->mCaretFrame = nullptr;
>    state->mFirstFrameMarkedForDisplay = mFramesMarkedForDisplay.Length();
>  
> +#ifdef DEBUG
> +  state->mAutoLayoutPhase.emplace(aReferenceFrame->PresContext(), eLayoutPhase_DisplayListBuilding);                                                                                

lots of end-of-line whitespace here
Attachment #8911025 - Flags: review?(mstange) → review+
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df95a1b7d718
Add a new layout phase for displaylist building. r=mstange
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/df95a1b7d718
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.