1402206 - Print error name for MFR::OnSeekFail

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Alastor Wu [:alwu]]

Print error code couldn't effectively help people understand the reason of error, we should print its name. [1]

[1] http://searchfox.org/mozilla-central/rev/2ef8bd8a46a02c68ddbb1d5f25fa254dd7be1fbd/dom/media/MediaFormatReader.cpp#2822

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1402206 - print error name for MediaFormatReader::OnSeekFailed().

Print error code couldn't effectively help people understand the reason of error, we should print its name.

Review commit: https://reviewboard.mozilla.org/r/182510/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182510/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8911031 [details]
Bug 1402206 - print error name for MediaFormatReader::OnSeekFailed().

https://reviewboard.mozilla.org/r/182510/#review187840

what about adding this information in HTMLMediaElement::error.message ?

::: dom/media/MediaResult.h:48
(Diff revision 1)
>  
>    nsresult Code() const { return mCode; }
> +  nsCString ErrorName() const
> +  {
> +    nsCString name;
> +    GetErrorName(mCode, static_cast<nsACString&>(name));

you don't need the cast.

not sure why the cast was added elsewhere.

Comment 3

[Alastor Wu [:alwu]]

(In reply to Jean-Yves Avenard [:jya] from comment #2)
> ::: dom/media/MediaResult.h:48
> (Diff revision 1)
> >  
> >    nsresult Code() const { return mCode; }
> > +  nsCString ErrorName() const
> > +  {
> > +    nsCString name;
> > +    GetErrorName(mCode, static_cast<nsACString&>(name));
> 
> you don't need the cast.
> 
> not sure why the cast was added elsewhere.

OK, I'll also remove the cast in Description().

Comment 4

[Alastor Wu [:alwu]]

Comment on attachment 8911031 [details]
Bug 1402206 - print error name for MediaFormatReader::OnSeekFailed().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182510/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0916366739b8
print error name for MediaFormatReader::OnSeekFailed(). r=jya

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0916366739b8