Closed Bug 1402210 Opened 3 years ago Closed 3 years ago

Add payment UI documentation and do minor code cleanup

Categories

(Firefox :: WebPayments UI, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- unaffected
firefox58 --- fixed

People

(Reporter: MattN, Assigned: MattN)

Details

Attachments

(1 file)

Since the WebPayments UI framework is a bit complicated due to the process and privilege separation, it would be useful to document how each JS file and give an overview of how the files work together. This documentation can also help with an  architecture security review.

While documenting things I also found a few minor code simplifications.
Comment on attachment 8911040 [details]
Bug 1402210 - Add payment UI documentation and do minor code cleanup.

https://reviewboard.mozilla.org/r/182518/#review187824

All good. Nice and clear.
Attachment #8911040 - Flags: review?(mcaceres) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/fd4b9c72b832
Add payment UI documentation and do minor code cleanup. r=marcosc
https://hg.mozilla.org/mozilla-central/rev/fd4b9c72b832
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Toolkit → Firefox
Target Milestone: mozilla58 → Firefox 58
You need to log in before you can comment on or make changes to this bug.