140222 - Drag and drop of mails do not expand subfolders tree list on Mac

Status: VERIFIED WORKSFORME

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Frederic Bezies]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.9+)
Gecko/20020425
BuildID:    2002042510

When I try to drag and drop mails from folders to others, trees where folder
target is do not expand.

It worked in branch-1.0.0 builds, but not seems to work in trunk builds since
one day or two.

I can see it on 2002042503 and 2002042510 builds.

Reproducible: Always
Steps to Reproduce:
1.Select a mail
2.Try to drag and drop it in a sub-folder.


Actual Results:  Folder containing subfolder "target" is only highlighted.

Expected Results:  Folder must open, and show subfolders in it.

I see it in classic theme. Do not try modern one. I search on bugzilla, but
cannot find something like this bug.

Comment 1

[Antonio.Xu]

i had researched this bug,i found this bug is due to tree'object notify() 
function can not been runned when mouse button down,so i don't think this is a 
mailnews bug,it should been a layout bug,somebody must be fix it bug in tree 
object.you can tested it in bookmark,you can found this bug still open.

Comment 2

[Antonio.Xu]

this is a  well-defined bug,it is due to mozilla's timer can not running,when 
drag happen,i debug nsTimerImpl.cpp and nsAppshell.cpp,i found when drag 
happen,the timer has been blocked in nsAppshell::run(),so i add a patch,only 
for this bug,i hope somebody can saw it,maybe have good advice to me,Thank you. 

Comment 3

[Antonio.Xu]

Attachment: This is a first patch,only for this bug,please rv my patch

i didn't use timer when we drag and want open open a subfolder ,because timer
can not run notify,because all timer been blocked by mouse down event,so i
didn't use timer,i hope somebody can give me some good advice,please rv my
patch

Comment 4

[Stuart Parmenter]

i expect that the timer was used for some reason, but i don't know what that
reason is.  you might want to talk to bryner or hyatt about the tree code.  I
wonder if this problem is cross platform?  Should the windows drag and drop
process timers?  cc'ing pink for drag and drop question.

Comment 5

[Mike Pinkerton (not reading bugmail)]

windows dnd should process timers, so i'm at a loss there. someone was just
asking me about this on irc wrt menu dnd last week. something must have broke
recently on the trunk.

that said, timers should be avoided during dnd because mac can't process them
(it's blocked in the OS during a drag).

Comment 6

[kmurray1115]

I'm seeing this in branch build 2002-05-09.

Comment 7

[Simon Coffey]

I'm seeing this on 1.0 RC2, Win 2k.  It worked in previous builds.. can't be
sure about RC1 though,  wasnt running it for long, maybe I didnt notice it.

Comment 8

[Peter Lairo]

WFM on 2002-05-20, winNT  in mail/news and browser (hasn't worked for a long time)

Now to get that annoying bug (#?) fixed where dragging from URL to sidebar (past
the personal toolbar) will cause the personal toolbar folders to pop open. :( 

A simple fix would be to delay opening the folders for 1 second on hover. ;)

Comment 9

[Peter Lairo]

Just noticed that DND into personal toolbar will open a *subfolder* once, but if
that wasn't the correct subfolder, it is not possible to have *that* DND
operation open another subfolder or to reopen the previously opened folder. (I
know, it's not mail/news).

BTW. This should be keyword: mozilla1.0.0

Comment 10

[Simon Coffey]

The DND message to mail news subfolder works for me in RC3.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Fred, it works for me with trunk build 2002070904 XP, could you check it and
close the bug ?

Comment 12

[Frederic Bezies]

Closing it, I forget that bug exists for a long time :-)

WFM (of course), with trunk build 2002071104 - WinXP

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

verified.  this was fixed recently by bug 167841

Comment 14

[Stewart Gordon]

This is a problem on the Mac version, in both Classic and Modern themes.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4b) Gecko/20030428

Time to reopen, adjusting hardware/platform accordingly.

Comment 15

[Stewart Gordon]

Still fails on 2003052903, Mac OS X.  Reopening.

Comment 16

[Stewart Gordon]

Tried again in 1.7a.  The tree expands under Windows, but not Mac.

Comment 17

[Wayne Mery (:wsmwk)]

Karsten, others,
Do you see this prob in SM 1.0 or SM 1.1?

Comment 18

[Georg Maaß]

In the Nighly Build of SM from 2007-01-19 Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a2pre) Gecko/20070119 SeaMonkey/1.5a drag and drop of emald does not work at all. The target folder is not selected and dropping there does not do anything.

Comment 19

[Georg Maaß]

In the Nightly Build Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a3pre) Gecko/20070217 SeaMonkey/1.5a this still does not work. No changes related to this problem since 2007-01-19.

Comment 20

[Georg Maaß]

In XulRunner applications (1.9.a6pre) on  Macintosh and also in SeaMonkey 2.0 we still have this problem. Drag and drop does not work in trees.

Comment 21

[Wayne Mery (:wsmwk)]

does this fail in thunderbird mac also?

Comment 22

[Wayne Mery (:wsmwk)]

does this fail in SM trunk?

Comment 23

[Serge Gautherie (:sgautherie)]

(I don't have a Mac.)

Comment 24

[Stefan [:stefanh]]

(SM trunk on mac)

Dragging and holding a message above a folder will expand the folder after a slight delay. Just dragging and dropping a message in a folder will not expand the folder.

Comment 25

[Wayne Mery (:wsmwk)]

Stefan, do you consider this to be WFM?  On windows this works (despite bug 327033) and delay before expand is normal.  Perhaps Georg can confirm.

Comment 26

[Georg Maaß]

I can confirm in Build identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090516 SeaMonkey/2.0b1pre this works too.

Comment 27

[Stefan [:stefanh]]

Let's close this as wfm. The original problem is surely gone.

Comment 28

[Wayne Mery (:wsmwk)]

Bryan, bug morphed in comment 14 to Mac from the original windows report. so to clarify the Mac end ... ludo and I are thinking the Mac case should be WONTFIX as unhelpful behavior in the mail UI, even though native Mac folder behavior is (apparently) immediate opening of folder. WDY think?

Comment 29

[Stefan [:stefanh]]

(In reply to comment #28)
> Bryan, bug morphed in comment 14 to Mac from the original windows report. so to
> clarify the Mac end ... ludo and I are thinking the Mac case should be WONTFIX
> as unhelpful behavior in the mail UI, even though native Mac folder behavior is
> (apparently) immediate opening of folder. WDY think?

Now when I look at Apple's Mail, I think the mac behaviour here is quite similar. But in Safari's bookmarks window the folder behaviour differ a bit. Dragging a bookmark to a folder will expand the folder after a sec or so - the difference is when you drag and immediately drop a bookmark in a folder: The target folder will then expand at the same moment you drop the bookmark.

Comment 30

[Wayne Mery (:wsmwk)]

v.WFM per clarkbw 
"I doubt there is real consistency to achieve so we might as well just do what we think is right"