Closed Bug 1402274 Opened 7 years ago Closed 7 years ago

Use 64kb chunks by default in IpcResourceUpdateQueue

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- unaffected
firefox58 --- fixed

People

(Reporter: nical, Assigned: nical)

References

Details

(Whiteboard: [wr-mvp] [gfx-noted])

Attachments

(1 file, 1 obsolete file)

Relevant comment from dvander in bug 1400532:

> On Windows, shmems should be allocated in 64KB chunks. That's the minimum size VirtualAlloc will return and anything else wastes address space.

We currently use 32k.
Priority: P3 → P1
Whiteboard: [wr-mvp][triage][gfx-noted] → [wr-mvp] [gfx-noted]
Attachment #8912618 - Flags: review?(dvander)
Sorry for the churn, some garbage had made it into the diff of the previous patch, somehow.
Attachment #8912618 - Attachment is obsolete: true
Attachment #8912618 - Flags: review?(dvander)
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5983c0af046d
Adjust the shm allocation size in IpcResourceUpdateQueue. r=dvander
https://hg.mozilla.org/mozilla-central/rev/5983c0af046d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: