1402287 - Stop the separator in the permissions dialog header from moving

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[:prathiksha]

Attachment: Screen Shot 2017-09-22 at 5.23.41 PM.png

See attachment ^

Comment 1

[:prathiksha]

Attachment: Bug 1402287 - Stop the separator in the permissions dialog header from moving.

Review commit: https://reviewboard.mozilla.org/r/182626/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182626/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8911130 [details]
Bug 1402287 - Stop the separator in the permissions dialog header from moving.

https://reviewboard.mozilla.org/r/182626/#review187932

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/344a2ba91f95
Stop the separator in the permissions dialog header from moving. r=johannh

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/344a2ba91f95

Comment 5

[:prathiksha]

Comment on attachment 8911130 [details]
Bug 1402287 - Stop the separator in the permissions dialog header from moving.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1373206
[User impact if declined]: just a polish bug
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no 
[Why is the change risky/not risky?]: simple style fix
[String changes made/needed]: no

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8911130 [details]
Bug 1402287 - Stop the separator in the permissions dialog header from moving.

recent regression, low risk fix, beta57+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/092cc740306c

Comment 8

[Saheda Reza [:Antora]]

This request is implemented on Latest Beta also Nightly. The separator has been removed .

Fixing bug is verified on Latest Beta --
Build ID    :20171026211016
User Agent  :Mozilla/5.0 (Windows NT 6.1; rv:57.0) Gecko/20100101 Firefox/57.0

Tested OS-- Windows7 32bit