1402314 - easy to leak a window with navigator.serviceWorker.ready promise

Status: RESOLVED WORKSFORME

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

This test site will end up leaking a window:

https://sw-never-ready.glitch.me/

It basically just blocking on navigator.serviceWorker.ready in a situation where a service worker never becomes active for the scope.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P1 Hold service worker ready promises weakly to avoid leaking windows. r=asuth

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Actually, I can't reproduce this now.  Looking at the code it does clean up the ready promise when the window is closed:

https://searchfox.org/mozilla-central/source/dom/workers/ServiceWorkerContainer.cpp#73

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: bug1402314_p2_mochitest.patch

For posterity, here are the tests I tried to write before realizing this WORKSFORME.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Attachment: bug1402314_p2_mochitest.patch