Closed Bug 1402318 Opened 3 years ago Closed 3 years ago

Implement the new photon syntax colors for the markup hidden elements

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: gl, Assigned: hodginsl2)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
New hidden node styling (lower priority than other color changes)
No hidden node indication for head/script tags
Desaturated colors instead of translucent for hidden divs and other elements
#A1A1A4 replaces blue
Gray 50 replaces magenta/Blue 70
Comment on attachment 8911377 [details]
Bug 1402318 - Implement the new photon syntax colors for the markup view.

https://reviewboard.mozilla.org/r/182864/#review188160
Attachment #8911377 - Flags: review?(gl) → review+
Summary: Implement the new photon syntax colors for the markup view → Implement the new photon syntax colors for the markup hidden elements
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fdecf61ce83e
Implement the new photon syntax colors for the markup hidden elements. r=gl
https://hg.mozilla.org/mozilla-central/rev/fdecf61ce83e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
https://hg.mozilla.org/integration/mozilla-inbound/rev/64231d7a9dc8587d1c34957818279991a0bfbb08

Backed out because of ux issues.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8911377 - Attachment is obsolete: true
Comment on attachment 8915361 [details]
Bug 1402318 - Implement the new photon syntax colors for the markup hidden elements

https://reviewboard.mozilla.org/r/186550/#review191706
Attachment #8915361 - Flags: review?(gl) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67d619db4280
Implement the new photon syntax colors for the markup hidden elements r=gl
https://hg.mozilla.org/mozilla-central/rev/67d619db4280
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Duplicate of this bug: 1400229
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.