Closed Bug 1402347 Opened 2 years ago Closed 2 years ago

Android application time out check is approximate

Categories

(Firefox for Android :: Testing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- fixed
firefox58 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

Android tests fail with "Application ran for longer than allowed maximum time" if the browser runs for too long. This is configured for 90 minutes currently. However, I have seen logs where the browser is running for 100 minutes or more without tripping this time out.
The existing code has some weaknesses, the worst of which being it does not account for non-sleep time (time reading the log, etc). This should make the check much more accurate.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8690e97abcd192d92b6891865bd3c0afc0976d2
Attachment #8911195 - Flags: review?(jmaher)
Comment on attachment 8911195 [details] [diff] [review]
improve accuracy of check for max run time

Review of attachment 8911195 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/mobile/remoteautomation.py
@@ +398,2 @@
>                  time.sleep(interval)
>                  timer += interval

do we still need to worry about timer?
Attachment #8911195 - Flags: review?(jmaher) → review+
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #2)
> do we still need to worry about timer?

Yes. It's still used for other, shorter-term decisions. I think it makes sense to keep that.
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18028ed94381
Be more exact in Android tests when checking run time; r=jmaher
https://hg.mozilla.org/mozilla-central/rev/18028ed94381
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
No longer blocks: 1411358
You need to log in before you can comment on or make changes to this bug.