1402347 - Android application time out check is approximate

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown]]

Android tests fail with "Application ran for longer than allowed maximum time" if the browser runs for too long. This is configured for 90 minutes currently. However, I have seen logs where the browser is running for 100 minutes or more without tripping this time out.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: improve accuracy of check for max run time

The existing code has some weaknesses, the worst of which being it does not account for non-sleep time (time reading the log, etc). This should make the check much more accurate.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8690e97abcd192d92b6891865bd3c0afc0976d2

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8911195 [details] [diff] [review]
improve accuracy of check for max run time

Review of attachment 8911195 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/mobile/remoteautomation.py
@@ +398,2 @@
>                  time.sleep(interval)
>                  timer += interval

do we still need to worry about timer?

Comment 3

[Geoff Brown [:gbrown]]

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #2)
> do we still need to worry about timer?

Yes. It's still used for other, shorter-term decisions. I think it makes sense to keep that.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18028ed94381
Be more exact in Android tests when checking run time; r=jmaher

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/18028ed94381

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/06f90b83cf20