Closed Bug 1402367 Opened 4 years ago Closed 4 years ago
Fix casing of windows includes in dom/media/platforms/wmf/WMFUtils
59 bytes, text/x-review-board-request
On Windows, filenames on case insensitive, but on Linux, they are not. Shlobj.h and Shlwapi.h cannot be found in the MinGW build because of this.
Are you saying that MinGW's headers are in lowercase? The Windows ones match the code: C:\SDK>dir /s /b /a shl*.h C:\SDK\10\Include\10.0.10586.0\um\ShlDisp.h C:\SDK\10\Include\10.0.10586.0\um\ShlGuid.h C:\SDK\10\Include\10.0.10586.0\um\ShlObj.h C:\SDK\10\Include\10.0.10586.0\um\Shlwapi.h C:\SDK\8.1\Include\um\ShlDisp.h C:\SDK\8.1\Include\um\ShlGuid.h C:\SDK\8.1\Include\um\ShlObj.h C:\SDK\8.1\Include\um\Shlwapi.h
(In reply to David Major [:dmajor] from comment #2) > Are you saying that MinGW's headers are in lowercase? The Windows ones match > the code: > > C:\SDK>dir /s /b /a shl*.h > C:\SDK\10\Include\10.0.10586.0\um\ShlDisp.h > C:\SDK\10\Include\10.0.10586.0\um\ShlGuid.h > C:\SDK\10\Include\10.0.10586.0\um\ShlObj.h > C:\SDK\10\Include\10.0.10586.0\um\Shlwapi.h > C:\SDK\8.1\Include\um\ShlDisp.h > C:\SDK\8.1\Include\um\ShlGuid.h > C:\SDK\8.1\Include\um\ShlObj.h > C:\SDK\8.1\Include\um\Shlwapi.h Yes, MinGW's headers are in lowercase. Microsoft isn't completely consistent, but does tend to put it in capitals: https://stackoverflow.com/a/15466951 I've fixed a bunch of these bugs before: Bug 1363465, Bug 1368416, Bug 1390617 and more that didn't come in a simple search.
Is there (or should there be) a bug against MinGW? I'll steal the review since Chris is out.
Comment on attachment 8911222 [details] Bug 1402367 Lowercase windows includes for MinGW build https://reviewboard.mozilla.org/r/182710/#review187984
Attachment #8911222 - Flags: review?(dmajor) → review+
(In reply to David Major [:dmajor] from comment #4) > Is there (or should there be) a bug against MinGW? I'll steal the review > since Chris is out. I think that ship has sailed. Since Linux is case sensitive, MinGW changing their casing would break (literally) everything.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f01e65b7038f Lowercase windows includes for MinGW build r=dmajor
You need to log in before you can comment on or make changes to this bug.