Closed Bug 1402367 Opened 4 years ago Closed 4 years ago

Fix casing of windows includes in dom/media/platforms/wmf/WMFUtils.cpp

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor])

Attachments

(1 file)

On Windows, filenames on case insensitive, but on Linux, they are not. Shlobj.h and Shlwapi.h cannot be found in the MinGW build because of this.
Are you saying that MinGW's headers are in lowercase? The Windows ones match the code:

C:\SDK>dir /s /b /a shl*.h
C:\SDK\10\Include\10.0.10586.0\um\ShlDisp.h
C:\SDK\10\Include\10.0.10586.0\um\ShlGuid.h
C:\SDK\10\Include\10.0.10586.0\um\ShlObj.h
C:\SDK\10\Include\10.0.10586.0\um\Shlwapi.h
C:\SDK\8.1\Include\um\ShlDisp.h
C:\SDK\8.1\Include\um\ShlGuid.h
C:\SDK\8.1\Include\um\ShlObj.h
C:\SDK\8.1\Include\um\Shlwapi.h
(In reply to David Major [:dmajor] from comment #2)
> Are you saying that MinGW's headers are in lowercase? The Windows ones match
> the code:
> 
> C:\SDK>dir /s /b /a shl*.h
> C:\SDK\10\Include\10.0.10586.0\um\ShlDisp.h
> C:\SDK\10\Include\10.0.10586.0\um\ShlGuid.h
> C:\SDK\10\Include\10.0.10586.0\um\ShlObj.h
> C:\SDK\10\Include\10.0.10586.0\um\Shlwapi.h
> C:\SDK\8.1\Include\um\ShlDisp.h
> C:\SDK\8.1\Include\um\ShlGuid.h
> C:\SDK\8.1\Include\um\ShlObj.h
> C:\SDK\8.1\Include\um\Shlwapi.h

Yes, MinGW's headers are in lowercase. Microsoft isn't completely consistent, but does tend to put it in capitals: https://stackoverflow.com/a/15466951

I've fixed a bunch of these bugs before: Bug 1363465, Bug 1368416, Bug 1390617 and more that didn't come in a simple search.
Is there (or should there be) a bug against MinGW? I'll steal the review since Chris is out.
Attachment #8911222 - Flags: review?(cpearce) → review?(dmajor)
Comment on attachment 8911222 [details]
Bug 1402367 Lowercase windows includes for MinGW build

https://reviewboard.mozilla.org/r/182710/#review187984
Attachment #8911222 - Flags: review?(dmajor) → review+
(In reply to David Major [:dmajor] from comment #4)
> Is there (or should there be) a bug against MinGW? I'll steal the review
> since Chris is out.

I think that ship has sailed. Since Linux is case sensitive, MinGW changing their casing would break (literally) everything.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f01e65b7038f
Lowercase windows includes for MinGW build r=dmajor
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f01e65b7038f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.