1402367 - Fix casing of windows includes in dom/media/platforms/wmf/WMFUtils.cpp

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

On Windows, filenames on case insensitive, but on Linux, they are not. Shlobj.h and Shlwapi.h cannot be found in the MinGW build because of this.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1402367 Lowercase windows includes for MinGW build

Review commit: https://reviewboard.mozilla.org/r/182710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182710/

Comment 2

[(Away)]

Are you saying that MinGW's headers are in lowercase? The Windows ones match the code:

C:\SDK>dir /s /b /a shl*.h
C:\SDK\10\Include\10.0.10586.0\um\ShlDisp.h
C:\SDK\10\Include\10.0.10586.0\um\ShlGuid.h
C:\SDK\10\Include\10.0.10586.0\um\ShlObj.h
C:\SDK\10\Include\10.0.10586.0\um\Shlwapi.h
C:\SDK\8.1\Include\um\ShlDisp.h
C:\SDK\8.1\Include\um\ShlGuid.h
C:\SDK\8.1\Include\um\ShlObj.h
C:\SDK\8.1\Include\um\Shlwapi.h

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

(In reply to David Major [:dmajor] from comment #2)
> Are you saying that MinGW's headers are in lowercase? The Windows ones match
> the code:
> 
> C:\SDK>dir /s /b /a shl*.h
> C:\SDK\10\Include\10.0.10586.0\um\ShlDisp.h
> C:\SDK\10\Include\10.0.10586.0\um\ShlGuid.h
> C:\SDK\10\Include\10.0.10586.0\um\ShlObj.h
> C:\SDK\10\Include\10.0.10586.0\um\Shlwapi.h
> C:\SDK\8.1\Include\um\ShlDisp.h
> C:\SDK\8.1\Include\um\ShlGuid.h
> C:\SDK\8.1\Include\um\ShlObj.h
> C:\SDK\8.1\Include\um\Shlwapi.h

Yes, MinGW's headers are in lowercase. Microsoft isn't completely consistent, but does tend to put it in capitals: https://stackoverflow.com/a/15466951

I've fixed a bunch of these bugs before: Bug 1363465, Bug 1368416, Bug 1390617 and more that didn't come in a simple search.

Comment 4

[(Away)]

Is there (or should there be) a bug against MinGW? I'll steal the review since Chris is out.

Comment 5

[(Away)]

Comment on attachment 8911222 [details]
Bug 1402367 Lowercase windows includes for MinGW build

https://reviewboard.mozilla.org/r/182710/#review187984

Comment 6

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

(In reply to David Major [:dmajor] from comment #4)
> Is there (or should there be) a bug against MinGW? I'll steal the review
> since Chris is out.

I think that ship has sailed. Since Linux is case sensitive, MinGW changing their casing would break (literally) everything.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f01e65b7038f
Lowercase windows includes for MinGW build r=dmajor

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f01e65b7038f