Closed Bug 1402378 Opened 4 years ago Closed 4 years ago

Port bug 1400390 to TB [Fix wrong colspan of media section in about:support]

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 58.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

From bug 1400390:
Go to about:support#media-info-tbody

The Media table has some rows with 2 columns and then some rows with 9 columns.

Since all the rows belong to the same table, it looks weird.

The first rows should use colspan="8" on the 2nd cell.
Attached patch fixColspan.patch (obsolete) — Splinter Review
Straight port of https://hg.mozilla.org/mozilla-central/rev/9a57f4e9c624
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8911240 - Flags: review?(jorgk)
Comment on attachment 8911240 [details] [diff] [review]
fixColspan.patch

Review of attachment 8911240 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/about-support/content/aboutSupport.xhtml
@@ +545,5 @@
>          </tbody>
>  
>          <tbody id="media-output-devices-tbody">
>            <tr>
> +            <th colspan="5" class="title-column">

Why are we doing 5 when M-C has 9?
Attached patch fixColspan.patchSplinter Review
Uh, sorry. old lenses. Fixed.
Attachment #8911240 - Attachment is obsolete: true
Attachment #8911240 - Flags: review?(jorgk)
Attachment #8911246 - Flags: review?(jorgk)
Comment on attachment 8911246 [details] [diff] [review]
fixColspan.patch

Straight port, thanks.
Attachment #8911246 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2fd8773a88ed
Port bug 1400390 to TB [Fix wrong colspan of media section in about:support]. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 58.0
You need to log in before you can comment on or make changes to this bug.