Closed
Bug 1402386
Opened 7 years ago
Closed 7 years ago
CamelCase devtools\client\inspector\components\inspector-tab-panel.js
Categories
(DevTools :: Inspector, enhancement, P3)
DevTools
Inspector
Tracking
(firefox57 fix-optional, firefox58 fixed)
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox57 | --- | fix-optional |
firefox58 | --- | fixed |
People
(Reporter: pbro, Assigned: pbro)
References
Details
Attachments
(1 file)
We recently agreed to name our React component file names using the CamelCase convention. devtools\client\inspector\components\inspector-tab-panel.js does not follow this convention, so let's rename this file. This is an easy fix, but make sure you read the contribution docs before starting: http://docs.firefox-dev.tools/ so that you can build Firefox locally and verify that things still work after your change. After building, just running the built Firefox and opening the inspector should be enough of a test.
Assignee | ||
Updated•7 years ago
|
status-firefox57:
--- → fix-optional
Assignee | ||
Comment 1•7 years ago
|
||
I'll take this small one to help the effort.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bcaa5fed92f36841f26f13fd78d4b4a0dedbe25
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8911788 [details] Bug 1402386 - CamelCase the inspector-tab-panel component; https://reviewboard.mozilla.org/r/183212/#review188748 LGTM! Honza
Attachment #8911788 -
Flags: review?(odvarko) → review+
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da264d9bdd7d CamelCase the inspector-tab-panel component; r=Honza
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/da264d9bdd7d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•