1402388 - AWFY - Firefox opening privacy notification tab during tests

Status: RESOLVED FIXED

(Testing Graveyard :: AWFY, enhancement)

Description

[Bob Clary [:bc] (inactive)]

While checking the running tests on AWFY, I noticed that Firefox had opened the privacy notification page in a background tab. I'm pretty sure we don't want that though I doubt it has much impact overall.

Bug Archaeology shows:

Bug 1400675 - Fix reference to undefined property FirsRunURL

Bug 1382196 - Use the prefs defined in TelemetryUtils.jsm in TelemetryReportingPolicy.jsm

Bug 1367076 - Set datareporting.policy.firstRunURL by default to replace data choices infobar with privacy policy in a background tab on first run.

The combination of these patches has resulted in Firefox opening the privacy tab on first run.

We should set:

user_pref("datareporting.policy.firstRunURL", "");

and reading the patches, probably need to set:

// Skip data reporting policy notifications.
user_pref("datareporting.policy.dataSubmissionPolicyBypassNotification", true);

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: https://github.com/mozilla/arewefastyet/pull/176

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Good call! (to wit, doc of these prefs: http://searchfox.org/mozilla-central/source/toolkit/components/telemetry/docs/internals/preferences.rst#84 )

Comment 3

[Bob Clary [:bc] (inactive)]

Thanks! That is very informative.

perhaps datareporting.policy.dataSubmissionEnabled False is another one we need to add?

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Yes indeed! (sorry I already merged the PR)

Comment 5

[Bob Clary [:bc] (inactive)]

Attachment: https://github.com/mozilla/arewefastyet/pull/177

If this is ok, go ahead and merge and mark fixed. Thanks!

Comment 6

[Benjamin Bouvier [:bbouvier] (inactive)]

Thanks, merged!