Closed Bug 1402401 Opened 7 years ago Closed 7 years ago

l10n nightlies fail if compare-locales detects errors after upgrade to 2.1

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox58 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: aryx, Assigned: Pike)

References

Details

(Whiteboard: [stockwell fixed:other])

Attachments

(1 file)

bug 1402401, don't break builds on broken locales,
59 bytes, text/x-review-board-request
stas
: review+
Details 
After bug 1382005 updated compare-locales to 2.1, nightlies for localizations for which compare-locales detects errors fail, see https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=2cd3752963fc8f24f7c202687eab55e83222f608&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-searchStr=tc-L10n

Both
belarussian (be) https://treeherder.mozilla.org/logviewer.html#?job_id=132675304&repo=mozilla-central
and
farsi (fa) https://treeherder.mozilla.org/logviewer.html#?job_id=132675340&repo=mozilla-central
contain

[task 2017-09-22T11:37:55.219Z] 11:37:55     INFO -        safebrowsing/phishing-afterload-warning-message.dtd
[task 2017-09-22T11:37:55.219Z] 11:37:55     INFO -            ERROR: not well-formed (invalid token) at line 50, column 163 for safeb.blocked.phishingPage.errorDesc.override
[task 2017-09-22T11:37:55.219Z] 11:37:55     INFO -            ERROR: not well-formed (invalid token) at line 52, column 165 for safeb.blocked.phishingPage.errorDesc.noOverride

Does this make it fatal?
Flags: needinfo?(l10n)
For more details, in ne-NP:

...
[task 2017-09-22T11:39:51.247Z] 11:39:51     INFO -          preferences
[task 2017-09-22T11:39:51.248Z] 11:39:51     INFO -            preferences.dtd
[task 2017-09-22T11:39:51.248Z] 11:39:51     INFO -                ERROR: reference is a CSS length at line 19, column 42 for searchField.width
...
[task 2017-09-22T11:39:51.375Z] 11:39:51     INFO -  ne-NP:
[task 2017-09-22T11:39:51.375Z] 11:39:51     INFO -  changed: 7149
[task 2017-09-22T11:39:51.375Z] 11:39:51     INFO -  changed_w: 32467
[task 2017-09-22T11:39:51.376Z] 11:39:51     INFO -  errors: 1
[task 2017-09-22T11:39:51.376Z] 11:39:51     INFO -  keys: 1338
[task 2017-09-22T11:39:51.376Z] 11:39:51     INFO -  missing: 702
[task 2017-09-22T11:39:51.376Z] 11:39:51     INFO -  missing_w: 7680
[task 2017-09-22T11:39:51.376Z] 11:39:51     INFO -  obsolete: 19
[task 2017-09-22T11:39:51.377Z] 11:39:51     INFO -  unchanged: 1673
[task 2017-09-22T11:39:51.377Z] 11:39:51     INFO -  unchanged_w: 7561
[task 2017-09-22T11:39:51.377Z] 11:39:51     INFO -  75% of entries changed
[task 2017-09-22T11:39:51.377Z] 11:39:51     INFO -  /builds/worker/workspace/build/src/toolkit/locales/l10n.mk:202: recipe for target 'merge-ne-NP' failed
[task 2017-09-22T11:39:51.377Z] 11:39:51    ERROR -  make[1]: *** [merge-ne-NP] Error 1
[task 2017-09-22T11:39:51.377Z] 11:39:51     INFO -  make[1]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/locales'
[task 2017-09-22T11:39:51.378Z] 11:39:51     INFO -  Makefile:102: recipe for target 'libs-ne-NP' failed
[task 2017-09-22T11:39:51.378Z] 11:39:51     INFO -  make: *** [libs-ne-NP] Error 2
I wonder if it's due to bug 1384981. In the meantime, I could at least mitigate by unapproving strings with errors.
Yeah, and it's going to be a single-character fix [1]. Gonna hack up a patch today.

[1] https://www.gnu.org/software/make/manual/html_node/Errors.html

I also found bug 1402560 when going through the errors.
Assignee: nobody → l10n
Flags: needinfo?(l10n)
sorry for the lag, workweek and event, try is green, asking for review.
Comment on attachment 8911791 [details]
bug 1402401, don't break builds on broken locales,

https://reviewboard.mozilla.org/r/183216/#review188390
Attachment #8911791 - Flags: review?(stas) → review+
Pushed by axel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b50170822d21
don't break builds on broken locales, r=stas
https://hg.mozilla.org/mozilla-central/rev/b50170822d21
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Whiteboard: [stockwell fixed:other]
Blocks: 1419672
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: