Closed Bug 1402414 Opened 4 years ago Closed 4 years ago

Port bug 1395651 to TB [Set the tab line color to #0a84ff (blue-50) when we control the tabs toolbar background color]

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 58.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Instead of always using Highlight, FX uses #0a84ff where the tab background color is directly defined by FX. Linux for example uses a systen color for the background. Also should here the tab line also be a system color.
Attached patch tabline.patchSplinter Review
Port of https://hg.mozilla.org/mozilla-central/rev/c8b5d382ff56
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8911268 - Flags: review?(jorgk)
Can you explain this further. Linux uses highlight, Mac uses #0a84ff and for Windows I see both in the patch.

I've applied the patch and see 0a84ff. Isn't that rather unfortunate? When you use a similar accent colour, you won't see the fixed colour. Using highlight at least bares the chance that Windows will use a highlight colour that contrasts the accent colour a bit.
Until now without the patch you saw the highlight color which is on Windows default theme near to #0a84ff, so no big change to today. Optimal would be when we could create the complementary color of the accent color and use this. Highlight on Windows is used for the classic and High Contrast themes.
Comment on attachment 8911268 [details] [diff] [review]
tabline.patch

I'm not convinced that this is a good decision, but we follow FF :-(

(In reply to Richard Marti (:Paenglab) from comment #3)
> Optimal would be when we could create the complementary color of the accent color and use
> this.
Well, I think two line colours would be enough. Whenever blue isn't good, we use the other one. As you know, I e-mailed Dão about it, but he never answered. Best to file a bug.
Attachment #8911268 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/988c15280e48
Port bug 1395651 to TB [Set the tab line color to #0a84ff (blue-50) when we control the tabs toolbar background color]. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 58.0
You need to log in before you can comment on or make changes to this bug.