Closed Bug 1402426 Opened 2 years ago Closed 2 years ago

removing the requirement to sign addons from talos and run from source

Categories

(Testing :: Talos, enhancement)

enhancement
Not set

Tracking

(firefox57 fixed, firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- fixed
firefox58 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

(Whiteboard: [PI:September])

Attachments

(1 file)

it appears that we should have the ability to run talos without signing now:
https://bugzilla.mozilla.org/show_bug.cgi?id=1361002#c10

this will help remove roadblocks for developers and help get bug 1336389 landed.
Whiteboard: [PI:September]
here is a try push with a comparison view:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=94bcde4920e6&newProject=try&newRevision=42f9e9893c6a08258b9dfae13e6c805f7c4c1a2a&framework=1

This doesn't remove the .xpi files (will do in a followup when this is landed), nor does it touch the web extensions work (needs more investigation)- ideally both of these in a different bug.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8911953 - Flags: review?(rwood)
Comment on attachment 8911953 [details] [diff] [review]
remove requirement for signing legacy addons

Review of attachment 8911953 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, just one question

::: testing/talos/talos/test.py
@@ +165,5 @@
>      2. Launch Firefox.
>      3. Measure the delta between firstPaint and sessionRestored.
>      """
>      extensions = \
> +        '${talos}/startup_test/sessionrestore/addon'

Just one question, so now somehow the browser automatically finds the addon just by pointing it to the addon directory (without specifying the actual .xpi name)?
Attachment #8911953 - Flags: review?(rwood) → review+
in this case we are installing the addon as files in a directory instead of a .xpi.
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #3)
> in this case we are installing the addon as files in a directory instead of
> a .xpi.

Ah that's what you meant in coment 1 re: removing .xpi files, I thought that just meant removing the *signed* xpi files, ok thanks
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23e5c31fbaea
removing the requirement to sign addons from talos and run from source. r=rwood
https://hg.mozilla.org/mozilla-central/rev/23e5c31fbaea
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
some of this was accidentally removed in bug 1397180 thanks to rebasing and mozreview.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/da9caebfed41
removing the requirement to sign addons from talos and run from source. reland as this was partially reverted in a mozreview rebase. r=me
Should this be re-resolved now?
Flags: needinfo?(jmaher)
as soon as this lands in mozilla-central it will get resolved :)
Flags: needinfo?(jmaher)
https://hg.mozilla.org/mozilla-central/rev/da9caebfed41
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Whiteboard: [PI:September] → [PI:September][checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-beta/rev/27a4dff9d4d5
Whiteboard: [PI:September][checkin-needed-beta] → [PI:September]
Blocks: 1412388
You need to log in before you can comment on or make changes to this bug.