1402426 - removing the requirement to sign addons from talos and run from source

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

it appears that we should have the ability to run talos without signing now:
https://bugzilla.mozilla.org/show_bug.cgi?id=1361002#c10

this will help remove roadblocks for developers and help get bug 1336389 landed.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: remove requirement for signing legacy addons

here is a try push with a comparison view:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=94bcde4920e6&newProject=try&newRevision=42f9e9893c6a08258b9dfae13e6c805f7c4c1a2a&framework=1

This doesn't remove the .xpi files (will do in a followup when this is landed), nor does it touch the web extensions work (needs more investigation)- ideally both of these in a different bug.

Comment 2

[Robert Wood [:rwood]]

Comment on attachment 8911953 [details] [diff] [review]
remove requirement for signing legacy addons

Review of attachment 8911953 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, just one question

::: testing/talos/talos/test.py
@@ +165,5 @@
>      2. Launch Firefox.
>      3. Measure the delta between firstPaint and sessionRestored.
>      """
>      extensions = \
> +        '${talos}/startup_test/sessionrestore/addon'

Just one question, so now somehow the browser automatically finds the addon just by pointing it to the addon directory (without specifying the actual .xpi name)?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

in this case we are installing the addon as files in a directory instead of a .xpi.

Comment 4

[Robert Wood [:rwood]]

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #3)
> in this case we are installing the addon as files in a directory instead of
> a .xpi.

Ah that's what you meant in coment 1 re: removing .xpi files, I thought that just meant removing the *signed* xpi files, ok thanks

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23e5c31fbaea
removing the requirement to sign addons from talos and run from source. r=rwood

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/23e5c31fbaea

Comment 7

[Mike Conley (:mconley) (:⚙️)]

(This is fantastic, thanks!)

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

some of this was accidentally removed in bug 1397180 thanks to rebasing and mozreview.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/da9caebfed41
removing the requirement to sign addons from talos and run from source. reland as this was partially reverted in a mozreview rebase. r=me

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Should this be re-resolved now?

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

as soon as this lands in mozilla-central it will get resolved :)

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/da9caebfed41

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/27a4dff9d4d5