Closed Bug 1402445 Opened 3 years ago Closed 3 years ago

Surface the "ERROR PROCESSING MOZBUILD FILE" error in Treeherder.

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox57 wontfix, firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: KWierso, Assigned: KWierso)

Details

Attachments

(1 file)

At the moment, when this error hits, Treeherder just shows the job as failed, but doesn't give any hint about the error unless you look through the log yourself.

With a small tweak, we should be able to get Treeherder to at least show the error from its main UI.
Dunno if you'd want to make this change, but it should let Treeherder show SOMETHING for these errors without any changes on Treeherder's side.
Assignee: nobody → wkocher
Comment on attachment 8911319 [details]
Bug 1402445 - Tweak the error message for errors processing mozbuild files

https://reviewboard.mozilla.org/r/182804/#review188082

I'm fairly confident there are tests that will also need updating: I remember writing relatively compressive tests for moz.build error reporting back in the day. `mach python-test python/mozbuild` is what you want to run.
As far as I can see, the same number of tests in python/mozbuild/mozbuild/test/frontend/ pass with and without this patch, and I don't see any other instances of "ERROR PROCESSING" in python/ https://dxr.mozilla.org/mozilla-central/search?q=ERROR+PROCESSING+path%3Apython&redirect=true
Comment on attachment 8911319 [details]
Bug 1402445 - Tweak the error message for errors processing mozbuild files

https://reviewboard.mozilla.org/r/182804/#review189084

::: python/mozbuild/mozbuild/frontend/reader.py:516
(Diff revision 1)
>  
>      def __str__(self):
>          s = StringIO()
>  
>          delim = '=' * 30
> -        s.write('\n%s\nERROR PROCESSING MOZBUILD FILE\n%s\n\n' % (delim, delim))
> +        s.write('\n%s\nFATAL ERROR PROCESSING MOZBUILD FILE\n%s\n\n' % (delim, delim))

Considering the number of errors treeherder is unable to find, I'm not convinced. Punting to gps.
Attachment #8911319 - Flags: review?(mh+mozilla)
Comment on attachment 8911319 [details]
Bug 1402445 - Tweak the error message for errors processing mozbuild files

Damn mozreview.
Attachment #8911319 - Flags: review?(gps)
Comment on attachment 8911319 [details]
Bug 1402445 - Tweak the error message for errors processing mozbuild files

https://reviewboard.mozilla.org/r/182804/#review189178
Attachment #8911319 - Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e57229ccdb9
Tweak the error message for errors processing mozbuild files r=gps
https://hg.mozilla.org/mozilla-central/rev/9e57229ccdb9
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.