Row selection styles should have more specificity than row hovering

RESOLVED FIXED in Firefox 58

Status

P3
normal
RESOLVED FIXED
2 years ago
9 months ago

People

(Reporter: Oriol, Assigned: Oriol)

Tracking

unspecified
Firefox 58

Firefox Tracking Flags

(firefox57 fix-optional, firefox58 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
1. Load data:application/json,[1,2]
2. Hover the first row, it becomes lightly highlighted.
3. Click it. The row becomes selected but this is not observable because the row is still hovered.
4. Hover the second row. The first row suddenly becomes heavily highlighted. This is confusing.

Expected:
1. Load data:application/json,[1,2]
2. Hover the first row, it becomes lightly highlighted.
3. Click it. The row becomes heavily highlighted.
4. Hover the second row. The second row becomes lightly highlighted and the first one stays heavily highlighted.
status-firefox57: --- → fix-optional
Priority: -- → P3
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
Comment on attachment 8912652 [details]
Bug 1402460 - Let row selection styles have more precedence than row hovering

https://reviewboard.mozilla.org/r/183978/#review190064

Works nice, thanks!

R+, but please put a comment in the code explaining why we are using `not(.selected)`.

Honza
Attachment #8912652 - Flags: review?(odvarko) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 4

2 years ago
OK, and I have also simplified some styles. I don't now how to request review again, so I use needinfo.
Flags: needinfo?(odvarko)
Comment on attachment 8912652 [details]
Bug 1402460 - Let row selection styles have more precedence than row hovering

https://reviewboard.mozilla.org/r/183978/#review190584

LGTM thanks!

Honza
(Assignee)

Updated

2 years ago
Flags: needinfo?(odvarko)
Keywords: checkin-needed

Comment 6

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/de65572822c6
Let row selection styles have more precedence than row hovering r=Honza
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/de65572822c6
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58

Updated

9 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.