Closed
Bug 1402497
Opened 7 years ago
Closed 7 years ago
GET /favicon.ico leads to a 404
Categories
(developer.mozilla.org Graveyard :: General, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jwhitlock, Unassigned)
Details
(Keywords: in-triage, Whiteboard: [specification][type:bug])
What did you do?
================
Load https://developer.mozilla.org/favicon.ico
What happened?
==============
A 404 Not Found is returned
What should have happened?
==========================
The use should get the "standard" favicon, either https://developer.cdn.mozilla.net/static/img/favicon32.png or https://developer.cdn.mozilla.net/static/img/favicon32.e1ca6d9bb933.png, either directly or via redirect.
Is there anything else we should know?
======================================
Browsers look for the element <link rel="shortcut icon" href="..." />, but some tools look in this known location, first introduced in 1999.
This is the most common 404 on MDN, and making it a good URL would make it easier to watch the remaining 404s for real problems.
Comment 1•7 years ago
|
||
We have a favicon.ico file in /static/img/
If you are going to do the work to put this file in the root directory would it also be possible to move and serve all the favicons from the root directory? I would love to be able to remove the 5 <link>s from the document head.
Reporter | ||
Comment 2•7 years ago
|
||
I'm not up to date on favicons. Are you saying this would work without the <links> in the document <head>?
GET /favicon144.png → 302 to /static/img/favicon144.0d89fc050967.png
GET /favicon114.png → 302 to /static/img/favicon114.57ce6f6d1857.png
GET /favicon72.png → 302 to /static/img/favicon72.deefe20a0360.png
GET /favicon57.png → 302 to /static/img/favicon57.930938a93373.png
GET /favicon32.png → 302 to /static/img/favicon32.e1ca6d9bb933.png
GET /favicon.ico → 302 to /static/img/favicon32.e1ca6d9bb933.png (same)
It seems to me that the higher resolution favicons will not be used if we remove the <link> attributes. It also seems the Wikipedia page is the main docs for this feature.
https://en.wikipedia.org/wiki/Favicon
Comment 3•7 years ago
|
||
We don't need versioning on these files.
What I would like is to have favicon144.png, favicon114.png, etc in the root folder.
Unless we think there are big downsides to not serving these from the CDN?
Reporter | ||
Comment 4•7 years ago
|
||
We don't have a mechanism for serving files in AWS, except through Kuma. If we moved these off the CDN, it would compete with page requests for web servers. I'd rather keep them on the CDN for now.
I'd like to limit this bug to /favicon.ico, and re-evaluate moving the other favicons after developer.mozilla.org is behind a CDN (no bug yet)
Comment 5•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/kuma
https://github.com/mozilla/kuma/commit/6624276cdf5cc7a51bc049a01aa2abeb2929ddff
bug 1402497: Redirect requests for /favicon.ico
https://github.com/mozilla/kuma/commit/a8163d297eea4272235068d54b358158badcccc1
Merge pull request #4443 from jwhitlock/favicon-1402497
bug 1402497: Redirect requests for /favicon.ico
Comment 6•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/kuma
https://github.com/mozilla/kuma/commit/6dc531010d07669dfc29df85d1f42e8b5f8995a9
bug 1402497: /favicon.ico redirect, try #2
The redirect pattern fails when hashed assets are enabled, such as
building the production Docker images. Instead, wait until runtime to
compute the favicon.ico path.
https://github.com/mozilla/kuma/commit/7dd1c0df5a38edad0c5e4890b249bc0a733a0c90
Merge pull request #4449 from jwhitlock/favicon2-1402497
bug 1402497: /favicon.ico redirect, try #2
Reporter | ||
Comment 7•7 years ago
|
||
https://developer.mozilla.org/favicon.ico now redirects to https://cdn.mdn.mozilla.net/static/img/favicon.78cc2f51b652.ico.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•