1402499 - Add NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED0

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

From bz's comment at https://bugzilla.mozilla.org/show_bug.cgi?id=1389650#c17:

"This is crying out for a NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED0 that just takes the parent class name.  Followup for that, please?

And as long as we're there, in that followup you could switch HTMLOutputElement to NS_IMPL_QUERY_INTERFACE_CYCLE_COLLECTION_INHERITED, I think."

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1402499 - Add NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED_0

Add macro for nsISupports inheriting classes that need cycle
collection and only inherit from one parent, with no interface table
needed. Takes care of map and addref/release calls.

Review commit: https://reviewboard.mozilla.org/r/185220/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185220/

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1402499 - Simplify HTMLAnchorElement CC macros;

The HTMLAnchorElement macros were basically a verbose version of the
CYCLE_COLLECTION_INHERITED helper macros.

Review commit: https://reviewboard.mozilla.org/r/185222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185222/

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Ok, these patches didn't turn out quite as planned, at least, based on the initial comment that created it.

AFAICT, HTMLAnchorElement didn't really need NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED_0 because it derives from both nsGenericHTMLElement and Link, so we need to state both interfaces, which NS_IMPL_ISUPPORTS_CYCLE_COLLECTION already does. I went ahead and cleaned that up.

However, HTMLCanvasElement, which I'm in the process of removing, CAN use NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED_0, so I'm still making the patch here to use in bug 1403819

As for HTMLObjectElement, I'm not quite sure how the conversion to NS_IMPL_QUERY_INTERFACE_CYCLE_COLLECTION_INHERITED would work? It already uses NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED and seems to need it?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8913837 [details]
Bug 1402499 - Add NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED_0

https://reviewboard.mozilla.org/r/185220/#review190730

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8913838 [details]
Bug 1402499 - Simplify HTMLAnchorElement CC macros;

https://reviewboard.mozilla.org/r/185222/#review190732

Comment 6

[Boris Zbarsky [:bzbarsky]]

> As for HTMLObjectElement, I'm not quite sure how the conversion to NS_IMPL_QUERY_INTERFACE_CYCLE_COLLECTION_INHERITED would work?

Output, not Object.  HTML_Output_Element could use NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED, afaict.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b8671193430
Add NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED_0 r=bz
https://hg.mozilla.org/integration/autoland/rev/91b6b53a5a72
Simplify HTMLAnchorElement CC macros; r=bz

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5b8671193430
https://hg.mozilla.org/mozilla-central/rev/91b6b53a5a72