test_gpuprocess.js ineffectively tries to kill the GPU process

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rhunt, Assigned: rhunt)

Tracking

unspecified
mozilla58
Points:
---

Firefox Tracking Flags

(firefox57 fix-optional, firefox58 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

At the end of the test, test_gpuprocess.js, will call 'controlGPUProcessForXPCShell(false)' which will kill the GPU process. [1]

The GPU process isn't disabled though, so it will be immediately restarted once the GPUProcessManager realizes the process has died.

Either we shouldn't bother trying to kill the GPU process at the end of the test, or we should kill and disable it.

[1] http://searchfox.org/mozilla-central/rev/15ce5cb2db0c85abbabe39a962b0e697c9ef098f/toolkit/components/aboutmemory/tests/xpcshell/test_gpuprocess.js#17
Flags: needinfo?(dvander)
The intent for the API was to make the GPU process more testable, i.e. start and kill it arbitrarily. So I think disabling it is the right call.
Flags: needinfo?(dvander)
Attachment #8912238 - Flags: review?(dvander)
Attachment #8912238 - Flags: review?(dvander) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e06e885db07d
Disable the GPU process in xpc-shell after we kill it to prevent extra restarts. (bug 1402500, r=dvander)
https://hg.mozilla.org/mozilla-central/rev/e06e885db07d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.