Closed
Bug 1402504
Opened 7 years ago
Closed 7 years ago
Use in-source annotations for Rooted types in hazard analysis
Categories
(Core :: JavaScript: GC, enhancement, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
27.77 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
RIght now, MOZ_HAS_ROOTED is ignored, because the analysis uses its own hardcoded logic for determining rootedness (including such awful things as looking for a "Rooted" prefix.)
|
Assignee | |
Comment 1•7 years ago
|
||
Make the default be whatever is marked MOZ_HAS_ROOTED, plus special-case annotations that should be removed gradually.
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8911382 [details] [diff] [review]
Switch to using in-source annotations more directly,
Carrying over review from bug 1401243.
Attachment #8911382 -
Flags: review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0e228638fe4
Switch to using in-source annotations more directly, r=jonco
|
||
Updated•7 years ago
|
Priority: -- → P3
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•