Closed Bug 1402504 Opened 4 years ago Closed 4 years ago

Use in-source annotations for Rooted types in hazard analysis

Categories

(Core :: JavaScript: GC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

RIght now, MOZ_HAS_ROOTED is ignored, because the analysis uses its own hardcoded logic for determining rootedness (including such awful things as looking for a "Rooted" prefix.)
Make the default be whatever is marked MOZ_HAS_ROOTED, plus special-case annotations that should be removed gradually.
Comment on attachment 8911382 [details] [diff] [review]
Switch to using in-source annotations more directly,

Carrying over review from bug 1401243.
Attachment #8911382 - Flags: review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0e228638fe4
Switch to using in-source annotations more directly, r=jonco
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/c0e228638fe4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.