Closed Bug 1402666 Opened 7 years ago Closed 7 years ago

Replace Replace("") and Replace(NS_LITERAL_CSTRING("")) with ReplaceLiteral("")

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox-esr52 --- wontfix
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

Details

Attachments

(3 files)

and Replace(NS_LITERAL_STRING("")) with ReplaceLiteral(u"").

Mostly green Try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bae27090e02ba865fdbfafbf069dde93a4bb2c19
MozReview-Commit-ID: s2hrTSkBiJ
Comment on attachment 8911531 [details] [diff] [review]
Part 1: Replace Replace("") with ReplaceLiteral("")

Part 1: Replace Replace("") with ReplaceLiteral("")
Attachment #8911531 - Flags: review?(erahm)
MozReview-Commit-ID: Ho2DHuomdi3
Attachment #8911533 - Flags: review?(erahm)
MozReview-Commit-ID: Ji6UdG32RF4
Attachment #8911534 - Flags: review?(erahm)
Attachment #8911531 - Flags: review?(erahm) → review+
Attachment #8911533 - Flags: review?(erahm) → review+
Attachment #8911534 - Flags: review?(erahm) → review+
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07ba2828b1b0
Part 1: Replace Replace("") with ReplaceLiteral(""). r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6ec34a9d13a
Part 2: Replace Replace(NS_LITERAL_CSTRING("")) with ReplaceLiteral(""). r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/73e0d4e121d3
Part 3: Replace Replace(NS_LITERAL_STRING("")) with ReplaceLiteral(u""). r=erahm
Component: String → XPCOM
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: