Closed
Bug 1402666
Opened 7 years ago
Closed 7 years ago
Replace Replace("") and Replace(NS_LITERAL_CSTRING("")) with ReplaceLiteral("")
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
Attachments
(3 files)
8.07 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
3.28 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
5.21 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
and Replace(NS_LITERAL_STRING("")) with ReplaceLiteral(u""). Mostly green Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bae27090e02ba865fdbfafbf069dde93a4bb2c19
Assignee | ||
Comment 1•7 years ago
|
||
MozReview-Commit-ID: s2hrTSkBiJ
Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8911531 [details] [diff] [review] Part 1: Replace Replace("") with ReplaceLiteral("") Part 1: Replace Replace("") with ReplaceLiteral("")
Attachment #8911531 -
Flags: review?(erahm)
Assignee | ||
Comment 3•7 years ago
|
||
MozReview-Commit-ID: Ho2DHuomdi3
Attachment #8911533 -
Flags: review?(erahm)
Assignee | ||
Comment 4•7 years ago
|
||
MozReview-Commit-ID: Ji6UdG32RF4
Attachment #8911534 -
Flags: review?(erahm)
Updated•7 years ago
|
Attachment #8911531 -
Flags: review?(erahm) → review+
Updated•7 years ago
|
Attachment #8911533 -
Flags: review?(erahm) → review+
Updated•7 years ago
|
Attachment #8911534 -
Flags: review?(erahm) → review+
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/07ba2828b1b0 Part 1: Replace Replace("") with ReplaceLiteral(""). r=erahm https://hg.mozilla.org/integration/mozilla-inbound/rev/f6ec34a9d13a Part 2: Replace Replace(NS_LITERAL_CSTRING("")) with ReplaceLiteral(""). r=erahm https://hg.mozilla.org/integration/mozilla-inbound/rev/73e0d4e121d3 Part 3: Replace Replace(NS_LITERAL_STRING("")) with ReplaceLiteral(u""). r=erahm
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/07ba2828b1b0 https://hg.mozilla.org/mozilla-central/rev/f6ec34a9d13a https://hg.mozilla.org/mozilla-central/rev/73e0d4e121d3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•3 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•