1402727 - Avoid a scroll bar (more often) when opening the main menu in touch mode

Status: NEW

(Firefox :: Menus, defect, P4)

Description

[Lazy Monkey]

Attachment: menu.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20170923100045

Steps to reproduce:

on my hp 2on1 touch win10 (10'') I tap on the top right icon to open the menu


Actual results:

the menu is opened but on the right there is an horrible scrollbar, that partially overlaps the menu icons


Expected results:

the menu should be opened without the scrollbar, or the scrollbar should not overlap icons

Comment 1

[Luke Usherwood]

+1. The larger menu rows when activated by touch is a great idea.

Still, on a Dell XPS 15 with 4k resolution (and 250% default scaling in Windows Control Panel), I'd expect the main menu should fit on screen fine.

The menu rows seem about 15% bigger than touch-activated context-menus in Outlook 2016, for example, and that amount of extra padding seems ample / about right to me.

Comment 2

[Luke Usherwood]

(further info: 57.0b4 (64-bit), Running on Win 10)

Comment 4

[:Gijs (away/busy until Mar 10)]

Reopening per requests in bug 1387808.

Comment 5

[:Gijs (away/busy until Mar 10)]

Relevant comments:

(In reply to Luke Usherwood from bug 1387808 comment #15)
> I feel the main menu should fit by default in a maximised FF window, even if
> touch-activated. With ~2000px of vertical space? (4k UHD @ 250% scaling
> here.) It only goes over by about 1 row.
> 
> Perhaps by making the rows expand less for touch? (I calculate 15% smaller
> would match the size of a touch-activated context menu in MS Outlook 2016,
> for example.) Or alternately by allowing them to squash down a bit, if
> they're "nearly" going to fit. (For some definition of "nearly".)


(In reply to Calvin Walton from bug 138708 comment #17)
> Created attachment 8916248 [details]
> firefox-menu-scrollbar-limited-height.png
> 
> As far as it goes, a small adjustment to height would only hide the problem
> for some users. This ss is from my 8" Windows touchscreen tablet, the menu
> is about half again as tall as the screen.
> 
> The previous customizable tile menu *did* fit (or at least almost fit), the
> new menu is just too vertical.
> It might be helpful to move more commonly used items "above the fold", so to
> speak, or even have a fixed panel that doesn't scroll above or below the
> lesser used entries.
> 
> Chrome's menu does fit on my screen, but it has fewer entries and is not
> using touch-friendly spacing.

Comment 6

[Mike de Boer [:mikedeboer]]

In bug 1387808 comment #14 I proposed the following solutions to be implemented here:

1. In `MenuTouchModeObserver`, dispatch a custom 'TouchModeChanged' event on the target node next to changing the 'touchmode' attribute, add a listener for the event in PanelMultiView.jsm
2. Or add a MutationObserver that listens to changes of the 'touchmode' attribute in PanelMultiView.jsm
3. Whenever we enter or leave touch mode, recalculate the dimensions of the mainView offscreen, cache 'em and set that as the constraints for the subviews.