1402767 - Enable accleleration of GLScreenBuffer when WebRender is enabled

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Sotaro Ikeda [:sotaro]]

It is not yet enabled with WebRender.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Enable accleleration of GLScreenBuffer when WebRender is enabled

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Enable accleleration of GLScreenBuffer when WebRender is enabled

Comment 3

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=65e97fbac70445c7993e1a0137e2b0cff119bb85

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8911666 [details] [diff] [review]
patch - Enable accleleration of GLScreenBuffer when WebRender is enabled

Review of attachment 8911666 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLScreenBuffer.cpp
@@ +76,5 @@
> +                 (backend == layers::LayersBackend::LAYERS_OPENGL ||
> +                  (backend == layers::LayersBackend::LAYERS_WR && !useANGLE));
> +    bool useD3D = !gfxPrefs::WebGLForceLayersReadback() &&
> +                  (backend == layers::LayersBackend::LAYERS_D3D11 ||
> +                   (backend == layers::LayersBackend::LAYERS_WR && useANGLE));

I would like these all to be const where possible.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Enable accleleration of GLScreenBuffer when WebRender is enabled

Apply the comment.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1637b28b7f90
Enable accleleration of GLScreenBuffer when WebRender is enabled r=jgilbert

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1637b28b7f90