Closed Bug 1402824 Opened 2 years ago Closed 2 years ago

Non-unified build fails in the xpcom/threads/ directory

Categories

(Core :: XPCOM, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(11 files)

59 bytes, text/x-review-board-request
luke
: review+
Details
59 bytes, text/x-review-board-request
billm
: review+
Details
59 bytes, text/x-review-board-request
billm
: review+
Details
59 bytes, text/x-review-board-request
smaug
: review+
Details
59 bytes, text/x-review-board-request
billm
: review+
Details
59 bytes, text/x-review-board-request
billm
: review+
Details
59 bytes, text/x-review-board-request
billm
: review+
Details
59 bytes, text/x-review-board-request
billm
: review+
Details
59 bytes, text/x-review-board-request
billm
: review+
Details
59 bytes, text/x-review-board-request
billm
: review+
Details
59 bytes, text/x-review-board-request
billm
: review+
Details
In support of exporting Gecko's media stack into a stand alone Rust crate for use by the Servo project, we need to make the XPCOM threading primitives and supporting code that the media stack relies upon build in non-unified mode.

Philippe Normand has a bunch of small fixes to various XPCOM threading and supporting classes to facilitate that.
Comment on attachment 8911759 [details]
Bug 1402824 - Include nsTArray.h in InputEventStatistics.h to fix non-unified build.

https://reviewboard.mozilla.org/r/183166/#review188338
Attachment #8911759 - Flags: review?(bugs) → review+
Comment on attachment 8911756 [details]
Bug 1402824 - Ensure mutationCount in HashTable.h is only used inside an JS_DEBUG ifdef.

https://reviewboard.mozilla.org/r/183160/#review188394
Attachment #8911756 - Flags: review?(luke) → review+
Comment on attachment 8911757 [details]
Bug 1402824 - Add missing includes in CooperativeThreadPool to fix non-unified build.

https://reviewboard.mozilla.org/r/183162/#review188504
Attachment #8911757 - Flags: review?(wmccloskey) → review+
Comment on attachment 8911758 [details]
Bug 1402824 - Include nsIRunnable in EventQueue.cpp to fix non-unified build.

https://reviewboard.mozilla.org/r/183164/#review188506
Attachment #8911758 - Flags: review?(wmccloskey) → review+
Comment on attachment 8911760 [details]
Bug 1402824 - Add missing includes in PrioritizedEventQueue to fix non-unified build.

https://reviewboard.mozilla.org/r/183168/#review188508
Attachment #8911760 - Flags: review?(wmccloskey) → review+
Comment on attachment 8911761 [details]
Bug 1402824 - Include Linkedlist.h in LabeledEventQueue to fix non-unified build.

https://reviewboard.mozilla.org/r/183170/#review188510
Attachment #8911761 - Flags: review?(wmccloskey) → review+
Comment on attachment 8911762 [details]
Bug 1402824 - Add missing includes in Scheduler.h to fix non-unified build.

https://reviewboard.mozilla.org/r/183172/#review188512
Attachment #8911762 - Flags: review?(wmccloskey) → review+
Comment on attachment 8911763 [details]
Bug 1402824 - Include nsIThreadInteral.h in SynchronizedEventQueue to fix non-unified.

https://reviewboard.mozilla.org/r/183174/#review188514
Attachment #8911763 - Flags: review?(wmccloskey) → review+
Comment on attachment 8911764 [details]
Bug 1402824 - Include AbstractThread in SystemGroup.cpp to fix non-unified build.

https://reviewboard.mozilla.org/r/183176/#review188516
Attachment #8911764 - Flags: review?(wmccloskey) → review+
Comment on attachment 8911765 [details]
Bug 1402824 - Include LabeledEventQueue.h in ThreadEventQueue.cpp to fix non-unified build.

https://reviewboard.mozilla.org/r/183178/#review188518
Attachment #8911765 - Flags: review?(wmccloskey) → review+
Comment on attachment 8911766 [details]
Bug 1402824 - Include nsComponentManagerUtils.h in nsThreadUtils.cpp to fix non-unified build.

https://reviewboard.mozilla.org/r/183180/#review188520
Attachment #8911766 - Flags: review?(wmccloskey) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d59a91b2f2d
Ensure mutationCount in HashTable.h is only used inside an JS_DEBUG ifdef. r=luke
https://hg.mozilla.org/integration/autoland/rev/db56e6da54d3
Add missing includes in CooperativeThreadPool to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/75e36b75f564
Include nsIRunnable in EventQueue.cpp to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/0ffa25137672
Include nsTArray.h in InputEventStatistics.h to fix non-unified build. r=smaug
https://hg.mozilla.org/integration/autoland/rev/ef139c527822
Add missing includes in PrioritizedEventQueue to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/52d49783fdd0
Include Linkedlist.h in LabeledEventQueue to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/a414320a4559
Add missing includes in Scheduler.h to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/1ac08c6d8373
Include nsIThreadInteral.h in SynchronizedEventQueue to fix non-unified. r=billm
https://hg.mozilla.org/integration/autoland/rev/e0dd9d0e8bc1
Include AbstractThread in SystemGroup.cpp to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/a3c51e77dccb
Include LabeledEventQueue.h in ThreadEventQueue.cpp to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/c17cf6e4ee95
Include nsComponentManagerUtils.h in nsThreadUtils.cpp to fix non-unified build. r=billm
Backed out for build bustage (mozilla/LabeledEventQueue.h not found):

https://hg.mozilla.org/integration/autoland/rev/cd1c3f84f3ec96ace1c361d249b80214fe52f672
https://hg.mozilla.org/integration/autoland/rev/99ab2cc7f7674dfb9d797229b596fb546c5eb8ab
https://hg.mozilla.org/integration/autoland/rev/30cc1898f50c438edef4e57d3296874229267394
https://hg.mozilla.org/integration/autoland/rev/2ac86f2bd9a52292b0ce407dc4ae0a4d67bcdb35
https://hg.mozilla.org/integration/autoland/rev/6baa4aec27abf0a2085fff5b06ac67426bf9c470
https://hg.mozilla.org/integration/autoland/rev/dd161d07dd6da8f769746eebd92c202d79aece0d
https://hg.mozilla.org/integration/autoland/rev/e7ac0b7b27029d0b32762739584199da61a154f3
https://hg.mozilla.org/integration/autoland/rev/79b553efb22d0ac0c10fecf2b6778d950cbf3813
https://hg.mozilla.org/integration/autoland/rev/a25425d3f88c1e8fb802a1489e7ec5f872341441
https://hg.mozilla.org/integration/autoland/rev/97bee5bbe57e3d592d17def2c05659c14b6ec905
https://hg.mozilla.org/integration/autoland/rev/d7c765ec3ac074ec40e7ca3b12f8d7fe39edd2d8

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c17cf6e4ee95f168cf7006b6f739e9be673da243&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=133280396&repo=autoland

[task 2017-09-26T08:02:39.943Z] 08:02:39     INFO -  In file included from /builds/worker/workspace/build/src/xpcom/threads/ThreadEventQueue.cpp:15:0,
[task 2017-09-26T08:02:39.943Z] 08:02:39     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/xpcom/threads/Unified_cpp_xpcom_threads1.cpp:38:
[task 2017-09-26T08:02:39.943Z] 08:02:39     INFO -  /builds/worker/workspace/build/src/xpcom/threads/PrioritizedEventQueue.h:11:39: fatal error: mozilla/LabeledEventQueue.h: No such file or directory
[task 2017-09-26T08:02:39.943Z] 08:02:39     INFO -   #include "mozilla/LabeledEventQueue.h"
[task 2017-09-26T08:02:39.943Z] 08:02:39     INFO -                                         ^
[task 2017-09-26T08:02:39.943Z] 08:02:39     INFO -  compilation terminated.
Flags: needinfo?(cpearce)
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7342b6583bc
Ensure mutationCount in HashTable.h is only used inside an JS_DEBUG ifdef. r=luke
https://hg.mozilla.org/integration/autoland/rev/1978d3213a4b
Add missing includes in CooperativeThreadPool to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/9929775b540b
Include nsIRunnable in EventQueue.cpp to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/5299d24f1e0b
Include nsTArray.h in InputEventStatistics.h to fix non-unified build. r=smaug
https://hg.mozilla.org/integration/autoland/rev/5994b4dee2b7
Add missing includes in PrioritizedEventQueue to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/bfaccb2f9e3d
Include Linkedlist.h in LabeledEventQueue to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/2060621594c2
Add missing includes in Scheduler.h to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/c6aaaf7cdf7d
Include nsIThreadInteral.h in SynchronizedEventQueue to fix non-unified. r=billm
https://hg.mozilla.org/integration/autoland/rev/226f257ca582
Include AbstractThread in SystemGroup.cpp to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/372be3cc35d9
Include LabeledEventQueue.h in ThreadEventQueue.cpp to fix non-unified build. r=billm
https://hg.mozilla.org/integration/autoland/rev/f934778255f0
Include nsComponentManagerUtils.h in nsThreadUtils.cpp to fix non-unified build. r=billm
Flags: needinfo?(cpearce)
You need to log in before you can comment on or make changes to this bug.