1402863 - Unpinning an edited Top Site wrongly renames that Top Site

Status: RESOLVED WONTFIX

(Firefox :: New Tab Page, defect)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: unpinned top sites renamed.gif

[Affected versions]:
- Firefox 58.0a1 Build ID 20170924220116

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Steps to reproduce]:
1. Open the browser and navigate to about:newtab.
2. Edit the name of a Top Site (eg. youtube -> YouTube)
3. Unpin the Top Site and observe its name.

[Expected results]:
- The Top Site is unpinned.

[Actual results]:
- The Top Site is unpinned, but it is also renamed to what it was called before the edit was made.

[Regression Window]:
Last good revision: 50d08bf45f3df9a5eacfc4531aafd85fd32875fd
First bad revision: 40b3b10f78c2d5a72356d21532add0848fc928b2
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=50d08bf45f3df9a5eacfc4531aafd85fd32875fd&tochange=40b3b10f78c2d5a72356d21532add0848fc928b2

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

Design says wontfix https://github.com/mozilla/activity-stream/issues/3594#issuecomment-337687089